linux-kernel - Re: [GIT PULL] Modules changes for v6.13-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQ1ahFWeChwBjgPs9Y3AGieVznFoPdbVkWP9rrW0T5-Dw@mail.gmail.com>
Date: Thu, 28 Nov 2024 11:48:24 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, samitolvanen@...gle.com, 
	petr.pavlu@...e.com, da.gomez@...sung.com, linux-modules@...r.kernel.org, 
	patches@...ts.linux.dev, linux-kernel@...r.kernel.org, mmaurer@...gle.com, 
	arnd@...db.de, deller@....de, song@...nel.org
Subject: Re: [GIT PULL] Modules changes for v6.13-rc1

On Thu, Nov 28, 2024 at 11:38 AM Luis Chamberlain <mcgrof@...nel.org> wrote:
>
> On Thu, Nov 28, 2024 at 11:09:43AM +0900, Masahiro Yamada wrote:
> > diff --git a/lib/tests/module/Makefile b/lib/tests/module/Makefile
> > index af5c27b996cb..8cfc4ae600a9 100644
> > --- a/lib/tests/module/Makefile
> > +++ b/lib/tests/module/Makefile
> > @@ -3,13 +3,12 @@ obj-$(CONFIG_TEST_KALLSYMS_B) += test_kallsyms_b.o
> >  obj-$(CONFIG_TEST_KALLSYMS_C) += test_kallsyms_c.o
> >  obj-$(CONFIG_TEST_KALLSYMS_D) += test_kallsyms_d.o
> >
> > -$(obj)/%.c: FORCE
> > -       @$(kecho) "  GEN     $@"
> > -       $(Q)$(srctree)/lib/tests/module/gen_test_kallsyms.sh $@\
> > -               $(CONFIG_TEST_KALLSYMS_NUMSYMS) \
> > -               $(CONFIG_TEST_KALLSYMS_SCALE_FACTOR)
> > +quiet_cmd_gen_test_kallsyms = GEN     $@
> > +      cmd_gen_test_kallsyms = $< $@ \
> > +       $(CONFIG_TEST_KALLSYMS_NUMSYMS) \
> > +       $(CONFIG_TEST_KALLSYMS_SCALE_FACTOR)
> >
> > -clean-files += test_kallsyms_a.c
> > -clean-files += test_kallsyms_b.c
> > -clean-files += test_kallsyms_c.c
> > -clean-files += test_kallsyms_d.c
> > +$(obj)/%.c: $(src)/gen_test_kallsyms.sh FORCE
>
> Thanks! We can also just replace the FORCE with $(KCONFIG_CONFIG), no?


Nope. Absolutely.

If you change any unrelated CONFIG option,
(e.g. CONFIG_DRIVER_FOO), the timestamp of .config
is updated, then lib/tests/module/test_kallsyms_*.c
are rebuilt for non good reason.







--
Best Regards
Masahiro Yamada