linux-kernel - Re: [PATCH] fat: use nls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87plmg9czb.fsf@mail.parknet.co.jp>
Date: Thu, 28 Nov 2024 13:52:24 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Wang Jianjian <wangjianjian3@...wei.com>, <linux-kernel@...r.kernel.org>,
        <wangjianjian0@...mail.com>
Subject: Re: [PATCH] fat: use nls_tolower simplify code

Wang Jianjian <wangjianjian3@...wei.com> writes:

> Signed-off-by: Wang Jianjian <wangjianjian3@...wei.com>

Looks good. Thanks.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> ---
>  fs/fat/dir.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index acbec5bdd521..88bf16204aab 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -214,10 +214,7 @@ fat_short2lower_uni(struct nls_table *t, unsigned char *c,
>  		*uni = 0x003f;	/* a question mark */
>  		charlen = 1;
>  	} else if (charlen <= 1) {
> -		unsigned char nc = t->charset2lower[*c];
> -
> -		if (!nc)
> -			nc = *c;
> +		unsigned char nc = nls_tolower(t, *c);
>  
>  		charlen = t->char2uni(&nc, 1, uni);
>  		if (charlen < 0) {

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>