linux-kernel - RE: [PATCH] scsi: ufs: core: Do not hold any lock in ufshcd_hba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL0PR04MB65641646D6F5CC2924DC77E6FC292@BL0PR04MB6564.namprd04.prod.outlook.com>
Date: Thu, 28 Nov 2024 07:13:46 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: core: Do not hold any lock in ufshcd_hba_stop

> Shouldn't the ufshcd_enable_irq() call be moved below the
> ufshcd_wait_for_register() call? Otherwise a race condition could cause the
> interrupt handler to be triggered while the controller is being disabled.
Correct.
if ufshcd_enable_irq() is called before the controller is fully disabled, it could allow interrupts to occur prematurely.
Will move it.

Thanks,
Avri
> 
> Thanks,
> 
> Bart.