linux-kernel - Re: [PATCH] spi: apple: Set use_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241128083142.GB3782493@robin.jannau.net>
Date: Thu, 28 Nov 2024 09:31:42 +0100
From: Janne Grunau <j@...nau.net>
To: fnkl.kernel@...il.com
Cc: Mark Brown <broonie@...nel.org>, Hector Martin <marcan@...can.st>,
	Sven Peter <sven@...npeter.dev>,
	Alyssa Rosenzweig <alyssa@...enzweig.io>, linux-spi@...r.kernel.org,
	asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: apple: Set use_gpio_descriptors to true

On Wed, Nov 27, 2024 at 11:18:29PM +0100, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein <fnkl.kernel@...il.com>
> 
> There is at least one peripheral that is attached to this
> controller and can not use native CS. Make it possible to use
> a GPIO instead.
> 
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@...il.com>
> ---
>  drivers/spi/spi-apple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi-apple.c b/drivers/spi/spi-apple.c
> index d4b126c8701a67083e7247d1c82fb56f1725d9cb..6273352a2b2861c9da0976a46ec2adbc4c71d3d2 100644
> --- a/drivers/spi/spi-apple.c
> +++ b/drivers/spi/spi-apple.c
> @@ -493,6 +493,7 @@ static int apple_spi_probe(struct platform_device *pdev)
>  	ctlr->prepare_message = apple_spi_prepare_message;
>  	ctlr->set_cs = apple_spi_set_cs;
>  	ctlr->transfer_one = apple_spi_transfer_one;
> +	ctlr->use_gpio_descriptors = true;
>  	ctlr->auto_runtime_pm = true;
>  
>  	pm_runtime_set_active(&pdev->dev);
> 

Reviewed-by: Janne Grunau <j@...nau.net>

Janne