linux-kernel - Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB11785EEAC5D646450D30E867F2292@MA0P287MB1178.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 28 Nov 2024 08:41:44 +0000
From: Bhavin Sharma <bhavin.sharma@...iconsignals.io>
To: Krzysztof Kozlowski <krzk@...nel.org>, "sre@...nel.org" <sre@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>
CC: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

Hi Krzysztof,

Thank you for your review.

> On 27/11/2024 16:19, Bhavin Sharma wrote:
> > +
> > +allOf:
> > +  - $ref: power-supply.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - st,stc3117
> > +
> > +  reg:
> > +    maxItems: 1
>
> I asked you some questions on v2, then on v3 and no responses.

I sincerely apologize for not addressing your questions in versions 2 and 3 
of the patch.

Regarding the battery configuration, we need the following information:
- Battery capacity
- Battery impedance
- OCV curve
- Minimum and maximum voltage
- Current sense register

Currently, I have set the battery capacity and impedance directly in the 
driver as default values. However, I understand these should ideally be 
defined in the device tree source (DTS). I will update the DTS accordingly
to include these parameters.

Additionally, since the OCV curve, minimum/maximum voltage, and sense
register values are fixed, I would like your opinion on whether these should
also be defined in the DTS or if it is acceptable to keep them in the driver itself.

Once again, I apologize for the oversight and thank you for your understanding.

Best regards,
Bhavin
________________________________________
From: Krzysztof Kozlowski <krzk@...nel.org>
Sent: Wednesday, November 27, 2024 11:52 PM
To: Bhavin Sharma <bhavin.sharma@...iconsignals.io>; sre@...nel.org <sre@...nel.org>; krzk+dt@...nel.org <krzk+dt@...nel.org>; robh@...nel.org <robh@...nel.org>; conor+dt@...nel.org <conor+dt@...nel.org>
Cc: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>; linux-pm@...r.kernel.org <linux-pm@...r.kernel.org>; devicetree@...r.kernel.org <devicetree@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

On 27/11/2024 16:19, Bhavin Sharma wrote:
> +
> +allOf:
> +  - $ref: power-supply.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - st,stc3117
> +
> +  reg:
> +    maxItems: 1

I asked you some questions on v2, then on v3 and no responses.

You implemented some changes but still did not answer my question. I am
not going to ask again, obviously expecting different result on the same
makes little sense.

No ack from me.

Best regards,
Krzysztof