linux-kernel - Re: [PATCH] media: qcom: camss: fix VFE pm domain off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acb6366a-aa6b-4c84-a3b2-cad03ae02ee7@linaro.org>
Date: Thu, 28 Nov 2024 11:10:26 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Yassine Oudjana <y.oudjana@...tonmail.com>,
 Barnabás Czémán <barnabas.czeman@...nlining.org>,
 Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Hans Verkuil <hverkuil@...all.nl>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: qcom: camss: fix VFE pm domain off

On 11/27/24 12:01, Yassine Oudjana wrote:
> On 22/11/2024 5:06 am, Barnabás Czémán wrote:
>> Fix NULL pointer check before device_link_del
>> is called.

The intention is clear, but the context of the change is completely lost.

>> Fixes: eb73facec2c2 ("media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable")

It's invalid, the change is not a fix.

>> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>> ---
>>    drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> ---
>> base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
>> change-id: 20241122-vfe_pm_domain_off-c57008e54167
>>
>> Best regards,
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
>> index 80a62ba11295042802cbaec617fb87c492ea6a55..1bf1473331f63b9ab106d21ea263c84d851c8a31 100644
>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
>> @@ -595,7 +595,7 @@ void vfe_isr_reset_ack(struct vfe_device *vfe)
>>     */
>>    void vfe_pm_domain_off(struct vfe_device *vfe)
>>    {
>> -	if (!vfe->genpd)
>> +	if (!vfe->genpd_link)
>>    		return;
>>    
>>    	device_link_del(vfe->genpd_link);
> 
> Tested-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> 

The change is useless and it shall be dropped.

--
Best wishes,
Vladimir