linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add USB SuperSpeed support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALE0LRu-Sx5oTVNY3hm+Msu-zb04a7_ZD+r3xF1eRfR_WtK0VA@mail.gmail.com>
Date: Thu, 28 Nov 2024 10:47:42 +0100
From: Enric Balletbo i Serra <eballetb@...hat.com>
To: s-vadapalli <s-vadapalli@...com>
Cc: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dasnavis Sabiya <sabiya.d@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add USB SuperSpeed support

Hi,

On Wed, Nov 27, 2024 at 11:00 AM Enric Balletbo i Serra
<eballetb@...hat.com> wrote:
>
> Hi,
>
> On Wed, Nov 27, 2024 at 9:27 AM s-vadapalli <s-vadapalli@...com> wrote:
> >
> > On Tue, Nov 26, 2024 at 11:08:19AM +0100, Enric Balletbo i Serra wrote:
> >
> > Hello Enric,
> >
> > > From: Dasnavis Sabiya <sabiya.d@...com>
> > >
> > > AM69 SK board has two stacked USB3 connectors:
> > >    1. USB3 (Stacked TypeA + TypeC)
> > >    2. USB3 TypeA Hub interfaced through TUSB8041.
> > >
> > > The board uses SERDES0 Lane 3 for USB3 IP. So update the
> > > SerDes lane info for PCIe and USB. Add the pin mux data
> > > and enable USB 3.0 support with its respective SERDES settings.
> > >
> > > Signed-off-by: Dasnavis Sabiya <sabiya.d@...com>
> > > Signed-off-by: Enric Balletbo i Serra <eballetb@...hat.com>
> > > ---
> > > I've been carrying this patch for quite long time in my builds to have
> > > support for USB on my AM69-SK board without problems. For some reason this
> > > patch was never send to upstream or I couldn't find it. So I took the
> > > opportunity, now that I rebased my build, to send upstream.
> > >
> > > I have maintained the original author of the downstream patch as is
> > > basically his work.
> > > ---
> > >  arch/arm64/boot/dts/ti/k3-am69-sk.dts | 33 +++++++++++++++++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> >
> > [...]
> >
> > > +&usb0 {
> > > +     status = "okay";
> > > +     dr_mode = "host";
> >
> > Since the Type-C interface is also connected to USB0, shouldn't "dr_mode"
> > be "otg"? Also, has the Type-C interface been tested with this patch?
> > Please let me know.
> >

So I changed the dr_mode to otg instead of host and tried to configure
a usb mass storage gadget but unfortunately didn't work, but this
could be a driver problem, I got the following error

  UDC core: g1: couldn't find an available UDC

As the devicetree should describe the hardware, and as far as I can
see it should support the type-c port act as a gadget, I'm fine with
changing the dr_mode, unless anyone have more information about this,
the thing that makes me think a bit more is that, in the TI kernel
this is set to host, so I'm wondering if I'm missing something or is
just that was never tested.

Thanks,
  Enric

>
> Yes, all usb from the board were tested. I'll try otg mode for the
> Type-C interface and resend the patch.
>
> $ lsusb -t
> /:  Bus 001.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 480M
>     |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 480M
>         |__ Port 001: Dev 003, If 0, Class=Hub, Driver=hub/4p, 480M
>             |__ Port 001: Dev 004, If 0, Class=Human Interface Device,
> Driver=usbhid, 1.5M
>             |__ Port 001: Dev 004, If 1, Class=Human Interface Device,
> Driver=usbhid, 1.5M
>         |__ Port 002: Dev 005, If 0, Class=Mass Storage,
> Driver=usb-storage, 480M
> /:  Bus 002.Port 001: Dev 001, Class=root_hub, Driver=xhci-hcd/1p, 5000M
>     |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 5000M
>         |__ Port 003: Dev 004, If 0, Class=Mass Storage,
> Driver=usb-storage, 5000M
>         |__ Port 004: Dev 003, If 0, Class=Mass Storage,
> Driver=usb-storage, 5000M
>
> Thanks,
>    Enric
> > [...]
> >
> > Regards,
> > Siddharth.
> >