linux-kernel - Re: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ldx3y6yf.ffs@tglx>
Date: Thu, 28 Nov 2024 11:43:20 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Eliav Farber <farbere@...zon.com>, linux@...linux.org.uk,
 catalin.marinas@....com, will@...nel.org, mpe@...erman.id.au,
 npiggin@...il.com, christophe.leroy@...roup.eu, naveen@...nel.org,
 maddy@...ux.ibm.com, paul.walmsley@...ive.com, palmer@...belt.com,
 aou@...s.berkeley.edu, akpm@...ux-foundation.org, bhe@...hat.com,
 farbere@...zon.com, hbathini@...ux.ibm.com, adityag@...ux.ibm.com,
 songshuaishuai@...ylab.org, takakura@...inux.co.jp,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org
Cc: jonnyc@...zon.com
Subject: Re: [PATCH v2] arm64: kexec: Check if IRQ is already masked before
 masking

On Wed, Nov 27 2024 at 15:22, Eliav Farber wrote:

As a related note. The subject line is not really matching what the
patch does. It want's to be split into a core change and one patch per
architecture.

> This patch replaces the direct invocation of the irq_mask() and

git grep 'This patch' Documentation/process/

> irq_disable() hooks with simplified code that leverages the
> irq_disable() kernel infrastructure. This higher-level function checks
> the interrupt's state to prevent redundant operations. Additionally, the
> IRQ_DISABLE_UNLAZY status flag is set to ensure that, for interrupt
> chips lacking an irq_disable callback, the disable operation is handled
> using the lazy approach.

Not that it matters much anymore, but the last sentence does not make
sense:

  Set the UNLAZY flag so disable is handled using the LAZY approach ...

Thanks,

        tglx