linux-kernel - Re: [PATCH 1/4] migrate: Allow migrate_misplaced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87plmfeho4.fsf@DESKTOP-5N7EMDA>
Date: Thu, 28 Nov 2024 19:12:11 +0800
From: "Huang, Ying" <ying.huang@...ux.alibaba.com>
To: Gregory Price <gourry@...rry.net>
Cc: linux-mm@...ck.org,  linux-kernel@...r.kernel.org,
  nehagholkar@...a.com,  abhishekd@...a.com,  kernel-team@...a.com,
  david@...hat.com,  ying.huang@...el.com,  nphamcs@...il.com,
  akpm@...ux-foundation.org,  hannes@...xchg.org,  feng.tang@...el.com,
  kbusch@...a.com
Subject: Re: [PATCH 1/4] migrate: Allow migrate_misplaced_folio APIs without
 a VMA

Hi, Gregory,

Gregory Price <gourry@...rry.net> writes:

> To migrate unmapped pagecache folios, migrate_misplaced_folio and
> migrate_misplaced_folio_prepare must handle folios without VMAs.

IMHO, it's better to use migrate_misplaced_folio() instead of
migrate_misplaced_folio for readability in patch title and description.

> migrate_misplaced_folio_prepare checks VMA for exec bits, so allow
> a NULL VMA when it does not have a mapping.
>
> migrate_misplaced_folio must call migrate_pages with MIGRATE_SYNC
> when in the pagecache path because it is a synchronous context.

I don't find the corresponding implementation for this.  And, I don't
think it's a good idea to change from MIGRATE_ASYNC to MIGRATE_SYNC.
This may cause too long page access latency for page placement
optimization.  The downside may offset the benefit.

And, it appears that we can delete the "vma" parameter of
migrate_misplaced_folio() because it's not used now.  This is a trivial
code cleanup.

> Suggested-by: Johannes Weiner <hannes@...xchg.org>
> Signed-off-by: Gregory Price <gourry@...rry.net>
> ---
>  mm/migrate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index dfb5eba3c522..3b0bd3f21ac3 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -2632,7 +2632,7 @@ int migrate_misplaced_folio_prepare(struct folio *folio,
>  		 * See folio_likely_mapped_shared() on possible imprecision
>  		 * when we cannot easily detect if a folio is shared.
>  		 */
> -		if ((vma->vm_flags & VM_EXEC) &&
> +		if (vma && (vma->vm_flags & VM_EXEC) &&
>  		    folio_likely_mapped_shared(folio))
>  			return -EACCES;

---
Best Regards,
Huang, Ying