linux-kernel - Re: [PATCH v2] selinux: add support for xperms in conditional policies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ2a_DcHZMkGuwPm69xD1VGnJe2Qjjucn8qRNJ65aqNS1VBAYw@mail.gmail.com>
Date: Thu, 28 Nov 2024 13:49:37 +0100
From: Christian Göttsche <cgzones@...glemail.com>
To: Paul Moore <paul@...l-moore.com>
Cc: selinux@...r.kernel.org, Stephen Smalley <stephen.smalley.work@...il.com>, 
	Ondrej Mosnacek <omosnace@...hat.com>, Thiébaud Weksteen <tweek@...gle.com>, 
	Bram Bonné <brambonne@...gle.com>, 
	Jacob Satterfield <jsatterfield.linux@...il.com>, Eric Suen <ericsu@...ux.microsoft.com>, 
	Casey Schaufler <casey@...aufler-ca.com>, John Johansen <john.johansen@...onical.com>, 
	Canfeng Guo <guocanfeng@...ontech.com>, GUO Zihua <guozihua@...wei.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selinux: add support for xperms in conditional policies

On Thu, 31 Oct 2024 at 23:20, Paul Moore <paul@...l-moore.com> wrote:
>
> On Wed, Oct 23, 2024 at 11:27 AM Christian Göttsche
> <cgoettsche@...tendoof.de> wrote:
> >
> > From: Christian Göttsche <cgzones@...glemail.com>
> >
> > Add support for extended permission rules in conditional policies.
> > Currently the kernel accepts such rules already, but evaluating a
> > security decision will hit a BUG() in
> > services_compute_xperms_decision().  Thus reject extended permission
> > rules in conditional policies for current policy versions.
> >
> > Add a new policy version for this feature.
> >
> > Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> > ---
> > v2:
> >   rebased onto the netlink xperm patch
> > ---
> >  security/selinux/include/security.h |  3 ++-
> >  security/selinux/ss/avtab.c         | 11 +++++++++--
> >  security/selinux/ss/avtab.h         |  2 +-
> >  security/selinux/ss/conditional.c   |  2 +-
> >  security/selinux/ss/policydb.c      |  5 +++++
> >  security/selinux/ss/services.c      | 12 ++++++++----
> >  6 files changed, 26 insertions(+), 9 deletions(-)
>
> This looks fine to me, but I believe there are some outstanding
> userspace issues that need to be resolved?

Hi,

I know it's very late in the development cycle, but I wanted to ask if
there is a chance this could be merged for 6.13?
The userspace patches are merged and currently part of 3.8-rc1, and
these kernel changes are quite simple, since most of the needed
functionality was already in place.
I created a testsuite patch over at
https://github.com/SELinuxProject/selinux-testsuite/pull/98.

>
> --
> paul-moore.com