linux-kernel - Re: [PATCH] selftest: hugetlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0290e481-48b2-48c5-acd1-66b80af66575@linux.ibm.com>
Date: Thu, 28 Nov 2024 18:28:29 +0530
From: Donet Tom <donettom@...ux.ibm.com>
To: Mark Brown <broonie@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>,
        "Ritesh Harjani (IBM)" <ritesh.list@...il.com>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftest: hugetlb_dio: Fix test naming


On 11/28/24 18:14, Mark Brown wrote:
> On Thu, Nov 28, 2024 at 10:46:56AM +0530, Donet Tom wrote:
>> On 11/27/24 21:44, Mark Brown wrote:
>>> +	ksft_test_result(free_hpage_a == free_hpage_b,
>>> +			 "free huge pages from %u-%u\n", start_off, end_off);
>> This test allocates a hugetlb buffer and adjusts the start and end offsets of the buffer based
>> on|start_off|  and|end_off|. The adjusted buffer is then used for Direct I/O (DIO). If I understand
>> correctly,|start_off|  and|end_off|  are not free huge pages but rather DIO buffer offsets. Should we
>> change this message to "Hugetlb DIO buffer offset"?
> Sure, so long as the message is consistent it doesn't really matter what
> it is from the point of view of the tooling.  I also noticed while doing
> this that the test doesn't verify that a huge page is actually used at
> any point, I was thinking about doing an incremental change for that
> too.

Sure. Thank you.

>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.