linux-kernel - Re: [PATCH v2 1/3] media: venus: Add support for static video encoder/decoder declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b97adbf2-f19f-4cd7-9266-526957c4c3d1@linaro.org>
Date: Thu, 28 Nov 2024 15:24:18 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: quic_renjiang@...cinc.com, quic_vnagar@...cinc.com,
 quic_dikshita@...cinc.com, konradybcio@...nel.org,
 linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Stanimir Varbanov <stanimir.varbanov@...aro.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/3] media: venus: Add support for static video
 encoder/decoder declarations

On 11/28/24 14:54, Bryan O'Donoghue wrote:
> On 28/11/2024 09:02, Vladimir Zapolskiy wrote:
>>> +    np = of_changeset_create_node(ocs, dev->of_node, node_name);
>>> +    if (!np) {
>>> +        dev_err(dev, "Unable to create new node\n");
>>> +        return -ENODEV;
>>
>> Leaked reference to np.
> 
> I don't believe that's a leak, because you only release np when it is
> non-NULL.
> 

Clearly it's my fault here, I'm very sorry for it.

--
Best wishes,
Vladimir