linux-kernel - Re: [PATCH v2] riscv: module: use a plain variable for list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5971ce3de4e5f59e8013b1c6a5bf4158c69e6b8.camel@iscas.ac.cn>
Date: Thu, 28 Nov 2024 22:24:27 +0800
From: laokz <zhangkai@...as.ac.cn>
To: Andrew Jones <ajones@...tanamicro.com>
Cc: Clément Léger <cleger@...osinc.com>, Paul Walmsley
	 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	 <aou@...s.berkeley.edu>, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Charlie Jenkins <charlie@...osinc.com>
Subject: Re: [PATCH v2] riscv: module: use a plain variable for list_head
 instead of a pointer

On Thu, 2024-11-28 at 09:32 +0100, Andrew Jones wrote:
> On Thu, Nov 28, 2024 at 09:01:52AM +0800, laokz wrote:
> > On Wed, 2024-11-27 at 15:25 +0100, Clément Léger wrote:
> > > rel_head's list_head member, rel_entry, doesn't need to be
> > > allocated,
> > > its storage can just be part of the allocated rel_head. Remove
> > > the
> > 
> > Oh my poor English. OK, it's more better than just add the lost
> > kfree.
> > 
> 
> It wasn't the English I was correcting. That was fine, but just
> saying
> the object could be "a plain variable" wasn't giving any
> justification
> for the change and, to me, even implied that rel_entry was locally
> scoped. So, when I first skimmed the patch and saw that it was
> getting
> appended to a list, I almost stated the patch was wrong. It was clear
> after looking closer, but it could have been clear the first time
> through if the commit message had better guided me.

Thanks for the explanation.
laokz

> Thanks,
> drew