| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202411282222.oF0B4110-lkp@intel.com>
Date: Thu, 28 Nov 2024 23:05:06 +0800
From: kernel test robot <lkp@...el.com>
To: David Laight <David.Laight@...lab.com>,
Linus Torvalds <torvalds@...ux-foundation.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
LKML <linux-kernel@...r.kernel.org>,
'Arnd Bergmann' <arnd@...nel.org>, 'Jens Axboe' <axboe@...nel.dk>,
'Matthew Wilcox' <willy@...radead.org>,
'Christoph Hellwig' <hch@...radead.org>,
'Andrew Morton' <akpm@...ux-foundation.org>,
Linux Memory Management List <linux-mm@...ck.org>,
'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>,
'Dan Carpenter' <dan.carpenter@...aro.org>,
"'Jason A . Donenfeld'" <Jason@...c4.com>,
"'pedro.falcato@...il.com'" <pedro.falcato@...il.com>,
'Mateusz Guzik' <mjguzik@...il.com>,
'Lorenzo Stoakes' <lorenzo.stoakes@...cle.com>
Subject: Re: [PATCH next 6/7] minmax.h: Simplify the variants of clamp()
Hi David,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20241121]
url: https://github.com/intel-lab-lkp/linux/commits/David-Laight/minmax-h-Add-whitespace-around-operators-and-after-commas/20241121-152617
base: next-20241121
patch link: https://lore.kernel.org/r/8f69f4deac014f558bab186444bac2e8%40AcuMS.aculab.com
patch subject: [PATCH next 6/7] minmax.h: Simplify the variants of clamp()
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20241128/202411282222.oF0B4110-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411282222.oF0B4110-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411282222.oF0B4110-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/iio/magnetometer/yamaha-yas530.c:30:
In file included from include/linux/i2c.h:13:
In file included from include/linux/acpi.h:14:
In file included from include/linux/device.h:32:
In file included from include/linux/device/driver.h:21:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/magnetometer/yamaha-yas530.c:414:20: warning: implicit conversion from 'unsigned long' to 'typeof (h[i])' (aka 'int') changes value from 18446744073709543424 to -8192 [-Wconstant-conversion]
414 | clamp_val(h[i], -BIT(13), BIT(13) - 1);
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:233:66: note: expanded from macro 'clamp_val'
233 | #define clamp_val(val, lo, hi) __careful_clamp(typeof(val), val, lo, hi)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
include/linux/minmax.h:197:26: note: expanded from macro '__careful_clamp'
197 | __clamp_once(type, val, lo, hi, __UNIQUE_ID(v_), __UNIQUE_ID(l_), __UNIQUE_ID(h_))
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:188:14: note: expanded from macro '__clamp_once'
188 | type ulo = (lo); \
| ~~~ ^~
5 warnings generated.
vim +414 drivers/iio/magnetometer/yamaha-yas530.c
de8860b1ed4701 Linus Walleij 2020-12-24 358
65f79b50103067 Jakob Hauser 2022-08-13 359 /**
65f79b50103067 Jakob Hauser 2022-08-13 360 * yas537_measure() - Make a measure from the hardware
65f79b50103067 Jakob Hauser 2022-08-13 361 * @yas5xx: The device state
65f79b50103067 Jakob Hauser 2022-08-13 362 * @t: the raw temperature measurement
65f79b50103067 Jakob Hauser 2022-08-13 363 * @x: the raw x axis measurement
65f79b50103067 Jakob Hauser 2022-08-13 364 * @y1: the y1 axis measurement
65f79b50103067 Jakob Hauser 2022-08-13 365 * @y2: the y2 axis measurement
65f79b50103067 Jakob Hauser 2022-08-13 366 * @return: 0 on success or error code
65f79b50103067 Jakob Hauser 2022-08-13 367 */
65f79b50103067 Jakob Hauser 2022-08-13 368 static int yas537_measure(struct yas5xx *yas5xx, u16 *t, u16 *x, u16 *y1, u16 *y2)
de8860b1ed4701 Linus Walleij 2020-12-24 369 {
65f79b50103067 Jakob Hauser 2022-08-13 370 struct yas5xx_calibration *c = &yas5xx->calibration;
65f79b50103067 Jakob Hauser 2022-08-13 371 unsigned int busy;
65f79b50103067 Jakob Hauser 2022-08-13 372 u8 data[8];
65f79b50103067 Jakob Hauser 2022-08-13 373 u16 xy1y2[3];
65f79b50103067 Jakob Hauser 2022-08-13 374 s32 h[3], s[3];
65f79b50103067 Jakob Hauser 2022-08-13 375 int i, ret;
65f79b50103067 Jakob Hauser 2022-08-13 376
65f79b50103067 Jakob Hauser 2022-08-13 377 mutex_lock(&yas5xx->lock);
65f79b50103067 Jakob Hauser 2022-08-13 378
65f79b50103067 Jakob Hauser 2022-08-13 379 /* Contrary to YAS530/532, also a "cont" bit is set, meaning unknown */
65f79b50103067 Jakob Hauser 2022-08-13 380 ret = regmap_write(yas5xx->map, YAS537_MEASURE, YAS5XX_MEASURE_START |
65f79b50103067 Jakob Hauser 2022-08-13 381 YAS5XX_MEASURE_CONT);
65f79b50103067 Jakob Hauser 2022-08-13 382 if (ret < 0)
65f79b50103067 Jakob Hauser 2022-08-13 383 goto out_unlock;
65f79b50103067 Jakob Hauser 2022-08-13 384
65f79b50103067 Jakob Hauser 2022-08-13 385 /* Use same timeout like YAS530/532 but the bit is in data row 2 */
65f79b50103067 Jakob Hauser 2022-08-13 386 ret = regmap_read_poll_timeout(yas5xx->map, YAS5XX_MEASURE_DATA + 2, busy,
65f79b50103067 Jakob Hauser 2022-08-13 387 !(busy & YAS5XX_MEASURE_DATA_BUSY),
65f79b50103067 Jakob Hauser 2022-08-13 388 500, 20000);
65f79b50103067 Jakob Hauser 2022-08-13 389 if (ret) {
65f79b50103067 Jakob Hauser 2022-08-13 390 dev_err(yas5xx->dev, "timeout waiting for measurement\n");
65f79b50103067 Jakob Hauser 2022-08-13 391 goto out_unlock;
65f79b50103067 Jakob Hauser 2022-08-13 392 }
65f79b50103067 Jakob Hauser 2022-08-13 393
65f79b50103067 Jakob Hauser 2022-08-13 394 ret = regmap_bulk_read(yas5xx->map, YAS5XX_MEASURE_DATA,
65f79b50103067 Jakob Hauser 2022-08-13 395 data, sizeof(data));
65f79b50103067 Jakob Hauser 2022-08-13 396 if (ret)
65f79b50103067 Jakob Hauser 2022-08-13 397 goto out_unlock;
65f79b50103067 Jakob Hauser 2022-08-13 398
65f79b50103067 Jakob Hauser 2022-08-13 399 mutex_unlock(&yas5xx->lock);
65f79b50103067 Jakob Hauser 2022-08-13 400
65f79b50103067 Jakob Hauser 2022-08-13 401 *t = get_unaligned_be16(&data[0]);
65f79b50103067 Jakob Hauser 2022-08-13 402 xy1y2[0] = FIELD_GET(GENMASK(13, 0), get_unaligned_be16(&data[2]));
65f79b50103067 Jakob Hauser 2022-08-13 403 xy1y2[1] = get_unaligned_be16(&data[4]);
65f79b50103067 Jakob Hauser 2022-08-13 404 xy1y2[2] = get_unaligned_be16(&data[6]);
65f79b50103067 Jakob Hauser 2022-08-13 405
65f79b50103067 Jakob Hauser 2022-08-13 406 /* The second version of YAS537 needs to include calibration coefficients */
65f79b50103067 Jakob Hauser 2022-08-13 407 if (yas5xx->version == YAS537_VERSION_1) {
65f79b50103067 Jakob Hauser 2022-08-13 408 for (i = 0; i < 3; i++)
65f79b50103067 Jakob Hauser 2022-08-13 409 s[i] = xy1y2[i] - BIT(13);
65f79b50103067 Jakob Hauser 2022-08-13 410 h[0] = (c->k * (128 * s[0] + c->a2 * s[1] + c->a3 * s[2])) / BIT(13);
65f79b50103067 Jakob Hauser 2022-08-13 411 h[1] = (c->k * (c->a4 * s[0] + c->a5 * s[1] + c->a6 * s[2])) / BIT(13);
65f79b50103067 Jakob Hauser 2022-08-13 412 h[2] = (c->k * (c->a7 * s[0] + c->a8 * s[1] + c->a9 * s[2])) / BIT(13);
65f79b50103067 Jakob Hauser 2022-08-13 413 for (i = 0; i < 3; i++) {
65f79b50103067 Jakob Hauser 2022-08-13 @414 clamp_val(h[i], -BIT(13), BIT(13) - 1);
65f79b50103067 Jakob Hauser 2022-08-13 415 xy1y2[i] = h[i] + BIT(13);
65f79b50103067 Jakob Hauser 2022-08-13 416 }
65f79b50103067 Jakob Hauser 2022-08-13 417 }
65f79b50103067 Jakob Hauser 2022-08-13 418
65f79b50103067 Jakob Hauser 2022-08-13 419 *x = xy1y2[0];
65f79b50103067 Jakob Hauser 2022-08-13 420 *y1 = xy1y2[1];
65f79b50103067 Jakob Hauser 2022-08-13 421 *y2 = xy1y2[2];
65f79b50103067 Jakob Hauser 2022-08-13 422
65f79b50103067 Jakob Hauser 2022-08-13 423 return 0;
65f79b50103067 Jakob Hauser 2022-08-13 424
65f79b50103067 Jakob Hauser 2022-08-13 425 out_unlock:
65f79b50103067 Jakob Hauser 2022-08-13 426 mutex_unlock(&yas5xx->lock);
65f79b50103067 Jakob Hauser 2022-08-13 427 return ret;
65f79b50103067 Jakob Hauser 2022-08-13 428 }
65f79b50103067 Jakob Hauser 2022-08-13 429
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists