linux-kernel - [PATCH] arm64: dts: fvp: Update bus-range property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241128152543.1821878-1-aneesh.kumar@kernel.org>
Date: Thu, 28 Nov 2024 20:55:43 +0530
From: "Aneesh Kumar K.V (Arm)" <aneesh.kumar@...nel.org>
To: linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: "Aneesh Kumar K.V (Arm)" <aneesh.kumar@...nel.org>,
	Liviu Dudau <liviu.dudau@....com>,
	Sudeep Holla <sudeep.holla@....com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Subject: [PATCH] arm64: dts: fvp: Update bus-range property

These days, the Fixed Virtual Platforms(FVP) Base RevC model supports
more PCI devices. Update the max bus number so that Linux can enumerate
them correctly. Without this, the kernel throws the below error while
booting with the default hierarchy

pci_bus 0000:01: busn_res: [bus 01] end is updated to 01
pci_bus 0000:02: busn_res: can not insert [bus 02-01] under [bus 00-01] (conflicts with (null) [bus 00-01])
pci_bus 0000:02: busn_res: [bus 02-01] end is updated to 02
pci_bus 0000:02: busn_res: can not insert [bus 02] under [bus 00-01] (conflicts with (null) [bus 00-01])
pci_bus 0000:03: busn_res: can not insert [bus 03-01] under [bus 00-01] (conflicts with (null) [bus 00-01])
pci_bus 0000:03: busn_res: [bus 03-01] end is updated to 03
pci_bus 0000:03: busn_res: can not insert [bus 03] under [bus 00-01] (conflicts with (null) [bus 00-01])
pci_bus 0000:04: busn_res: can not insert [bus 04-01] under [bus 00-01] (conflicts with (null) [bus 00-01])
pci_bus 0000:04: busn_res: [bus 04-01] end is updated to 04
pci_bus 0000:04: busn_res: can not insert [bus 04] under [bus 00-01] (conflicts with (null) [bus 00-01])
pci 0000:00:01.0: BAR 14: assigned [mem 0x50000000-0x500fffff]

The change is using 0xff as max bus nr because the ECAM window is 256MB in size.

pci-host-generic 40000000.pci: ECAM at [mem 0x40000000-0x4fffffff] for [bus 00-01]

lspci output with and without the change
without fix:
00:00.0 Host bridge: ARM Device 00ba (rev 01)
00:01.0 PCI bridge: ARM Device 0def
00:02.0 PCI bridge: ARM Device 0def
00:03.0 PCI bridge: ARM Device 0def
00:04.0 PCI bridge: ARM Device 0def
00:1e.0 Unassigned class [ff00]: ARM Device ff80
00:1e.1 Unassigned class [ff00]: ARM Device ff80
00:1f.0 SATA controller: Device 0abc:aced (rev 01)
01:00.0 SATA controller: Device 0abc:aced (rev 01)

with fix:
00:00.0 Host bridge: ARM Device 00ba (rev 01)
00:01.0 PCI bridge: ARM Device 0def
00:02.0 PCI bridge: ARM Device 0def
00:03.0 PCI bridge: ARM Device 0def
00:04.0 PCI bridge: ARM Device 0def
00:1e.0 Unassigned class [ff00]: ARM Device ff80
00:1e.1 Unassigned class [ff00]: ARM Device ff80
00:1f.0 SATA controller: Device 0abc:aced (rev 01)
01:00.0 SATA controller: Device 0abc:aced (rev 01)
02:00.0 Unassigned class [ff00]: ARM Device ff80
02:00.4 Unassigned class [ff00]: ARM Device ff80
03:00.0 PCI bridge: ARM Device 0def
04:00.0 PCI bridge: ARM Device 0def
04:01.0 PCI bridge: ARM Device 0def
04:02.0 PCI bridge: ARM Device 0def
05:00.0 SATA controller: Device 0abc:aced (rev 01)
06:00.0 Unassigned class [ff00]: ARM Device ff80
06:00.7 Unassigned class [ff00]: ARM Device ff80
07:00.0 Unassigned class [ff00]: ARM Device ff80
07:00.3 Unassigned class [ff00]: ARM Device ff80
08:00.0 Unassigned class [ff00]: ARM Device ff80
08:00.1 Unassigned class [ff00]: ARM Device ff80

Cc: Liviu Dudau <liviu.dudau@....com>
Cc: Sudeep Holla <sudeep.holla@....com>
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: Conor Dooley <conor+dt@...nel.org>
Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@...nel.org>
---
 arch/arm64/boot/dts/arm/fvp-base-revc.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
index 289c5f9d1c8d..225a1ed8aa08 100644
--- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts
+++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
@@ -233,7 +233,7 @@ pci: pci@...00000 {
 		#interrupt-cells = <0x1>;
 		compatible = "pci-host-ecam-generic";
 		device_type = "pci";
-		bus-range = <0x0 0x1>;
+		bus-range = <0x0 0xff>;
 		reg = <0x0 0x40000000 0x0 0x10000000>;
 		ranges = <0x2000000 0x0 0x50000000 0x0 0x50000000 0x0 0x10000000>;
 		interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.43.0