linux-kernel - Re: [PATCH] HID: i2c-hid: Revert to using power commands to wake on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173280844432.2348538.2409437012007158638.b4-ty@kernel.org>
Date: Thu, 28 Nov 2024 16:40:44 +0100
From: Benjamin Tissoires <bentiss@...nel.org>
To: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, 
 Kenny Levinsen <kl@...wtf>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Michael <auslands-kv@....de>, 
 Linux regressions mailing list <regressions@...ts.linux.dev>, 
 stable@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: Revert to using power commands to wake
 on resume

On Wed, 20 Nov 2024 00:53:17 +0100, Kenny Levinsen wrote:
> 7d6f065de37c ("HID: i2c-hid: Use address probe to wake on resume")
> replaced the retry of power commands with the dummy read "bus probe" we
> use on boot which accounts for a necessary delay before retry.
> 
> This made at least one Weida device (2575:0910 in an ASUS Vivobook S14)
> very unhappy, as the bus probe despite being successful somehow lead to
> the following power command failing so hard that the device never lets
> go of the bus. This means that even retries of the power command would
> fail on a timeout as the bus remains busy.
> 
> [...]

Applied to hid/hid.git (for-6.13/upstream-fixes), thanks!

[1/1] HID: i2c-hid: Revert to using power commands to wake on resume
      https://git.kernel.org/hid/hid/c/34851431ceca

Cheers,
-- 
Benjamin Tissoires <bentiss@...nel.org>