linux-kernel - Re: [PATCH] ima: instantiate the bprm_creds_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202411282320.KuWvLpDS-lkp@intel.com>
Date: Thu, 28 Nov 2024 23:57:04 +0800
From: kernel test robot <lkp@...el.com>
To: Mimi Zohar <zohar@...ux.ibm.com>, linux-integrity@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Mimi Zohar <zohar@...ux.ibm.com>,
	Mickaël Salaün <mic@...ikod.net>,
	roberto.sassu@...wei.com, linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ima: instantiate the bprm_creds_for_exec() hook

Hi Mimi,

kernel test robot noticed the following build errors:

[auto build test ERROR on zohar-integrity/next-integrity]
[also build test ERROR on linus/master v6.12 next-20241128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mimi-Zohar/ima-instantiate-the-bprm_creds_for_exec-hook/20241128-120656
base:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
patch link:    https://lore.kernel.org/r/20241127210234.121546-1-zohar%40linux.ibm.com
patch subject: [PATCH] ima: instantiate the bprm_creds_for_exec() hook
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20241128/202411282320.KuWvLpDS-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411282320.KuWvLpDS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411282320.KuWvLpDS-lkp@intel.com/

All errors (new ones prefixed by >>):

   security/integrity/ima/ima_main.c: In function 'ima_bprm_creds_for_exec':
>> security/integrity/ima/ima_main.c:572:18: error: 'struct linux_binprm' has no member named 'is_check'
     572 |         if (!bprm->is_check)
         |                  ^~
--
   security/integrity/ima/ima_appraise.c: In function 'is_bprm_creds_for_exec':
>> security/integrity/ima/ima_appraise.c:492:25: error: 'struct linux_binprm' has no member named 'is_check'
     492 |                 if (bprm->is_check)
         |                         ^~


vim +572 security/integrity/ima/ima_main.c

   556	
   557	/**
   558	 * ima_bprm_creds_for_exec - based on policy, collect/store/appraise measurement.
   559	 * @bprm: contains the linux_binprm structure
   560	 *
   561	 * Based on the IMA policy and the execvat(2) AT_CHECK flag, measure and
   562	 * appraise the integrity of a file to be executed by script interpreters.
   563	 * Unlike any of the other LSM hooks where the kernel enforces file integrity,
   564	 * enforcing file integrity is left up to the discretion of the script
   565	 * interpreter (userspace).
   566	 *
   567	 * On success return 0.  On integrity appraisal error, assuming the file
   568	 * is in policy and IMA-appraisal is in enforcing mode, return -EACCES.
   569	 */
   570	static int ima_bprm_creds_for_exec(struct linux_binprm *bprm)
   571	{
 > 572		if (!bprm->is_check)
   573			return 0;
   574	
   575		return ima_bprm_check(bprm);
   576	}
   577	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki