linux-kernel - Re: [PATCH RFC 2/6] mm/slub: add sheaf support for batching kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0iZOFAUSqN7cN5Z@pc636>
Date: Thu, 28 Nov 2024 17:24:24 +0100
From: Uladzislau Rezki <urezki@...il.com>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Vlastimil Babka <vbabka@...e.cz>,
	Suren Baghdasaryan <surenb@...gle.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Christoph Lameter <cl@...ux.com>,
	David Rientjes <rientjes@...gle.com>,
	Pekka Enberg <penberg@...nel.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Roman Gushchin <roman.gushchin@...ux.dev>,
	Hyeonggon Yoo <42.hyeyoo@...il.com>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Matthew Wilcox <willy@...radead.org>,
	Boqun Feng <boqun.feng@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, rcu@...r.kernel.org,
	maple-tree@...ts.infradead.org
Subject: Re: [PATCH RFC 2/6] mm/slub: add sheaf support for batching
 kfree_rcu() operations

On Mon, Nov 25, 2024 at 12:18:19PM +0100, Uladzislau Rezki wrote:
> > On 11/20/24 13:37, Uladzislau Rezki wrote:
> > > Thank you. Let me try to start moving it into mm/. I am thinking to place
> > > it to the slab_common.c file. I am not sure if it makes sense to have a
> > > dedicated file name for this purpose.
> >
> > Yeah sounds good. slub.c is becoming rather large and this should not
> > interact with SLUB internals heavily anyway, slab_common.c makes sense.
> > Thanks!
> >
> Got it :)
> 
There is one question. Do you think it works if i do a migration as one
big commit? I am asking, because it is easier to go that way.

If it looks ugly for you, we can use another approach which is to split
the work into several patches and deploy it a series.

--
Uladzislau Rezki