linux-kernel - Re: [PATCH v2 01/11] Revert "regulator: pca9450: Add sd-vsel GPIO"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241128-candle-guzzler-b7ea4e5ce643@spud>
Date: Thu, 28 Nov 2024 17:37:48 +0000
From: Conor Dooley <conor@...nel.org>
To: Frieder Schrempf <frieder@...s.de>
Cc: linux-arm-kernel@...ts.infradead.org, Marek Vasut <marex@...x.de>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
	Robin Gong <yibin.gong@....com>,
	Frieder Schrempf <frieder.schrempf@...tron.de>,
	Joy Zou <joy.zou@....com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2 01/11] Revert "regulator: pca9450: Add sd-vsel GPIO"

On Wed, Nov 27, 2024 at 05:42:17PM +0100, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
> 
> This reverts commit 27866e3e8a7e93494f8374f48061aa73ee46ceb2.
> 
> It turned out that this feature was implemented based on
> the wrong assumption that the SD_VSEL signal needs to be
> controlled as GPIO in any case.
> 
> In fact the straight-forward approach is to mux the signal
> as USDHC_VSELECT and let the USDHC controller do the job.
> 
> Most users never even used this property and the few who
> did have been or are getting migrated to the alternative
> approach.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
> ---
> Changes for v2:
> * split revert into separate patch
> ---
>  .../devicetree/bindings/regulator/nxp,pca9450-regulator.yaml | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> index f8057bba747a5..79fc0baf5fa2f 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> @@ -77,11 +77,6 @@ properties:
>  
>      additionalProperties: false
>  
> -  sd-vsel-gpios:
> -    description: GPIO that is used to switch LDO5 between being configured by
> -      LDO5CTRL_L or LDO5CTRL_H register. Use this if the SD_VSEL signal is
> -      connected to a host GPIO.

Your driver side of this, that I wasn't sent and cba downloading an
mbox of is not backwards compatible. The code has been there for a few
years, are you sure that there are no out of tree users or other OSes
that use the property?

tbh, I think all 3 of your dt-binding patches should be squashed rather
than drip-feeding the conversion. It makes more sense as a single
change, rather than splitting the rationales across 3 patches.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)