linux-kernel - Re: [PATCH bpf-next v3 2/2] bpf: Refactor bpf_tracing_func_proto() and remove bpf_get_probe_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQK0y_moywsFDsHLPsNZXnZQVJig7dN7J9khVv2gNq414g@mail.gmail.com>
Date: Thu, 28 Nov 2024 11:05:12 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Marco Elver <elver@...gle.com>
Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, 
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, Nikola Grcevski <nikola.grcevski@...fana.com>, 
	bpf <bpf@...r.kernel.org>, 
	linux-trace-kernel <linux-trace-kernel@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next v3 2/2] bpf: Refactor bpf_tracing_func_proto()
 and remove bpf_get_probe_write_proto()

On Thu, Nov 28, 2024 at 10:36 AM Marco Elver <elver@...gle.com> wrote:
>
> On Thu, Nov 28, 2024 at 10:22AM -0800, Alexei Starovoitov wrote:
> [..]
> > Moving bpf_base_func_proto() all the way to the top was incorrect,
> > but here we can move it just above this bpf_token_capable() check
> > and remove extra indent like:
> >
> > func_proto = bpf_base_func_proto();
> > if (func_proto)
> >    return func_proto;
> > if (!bpf_token_capable(prog->aux->token, CAP_SYS_ADMIN))
> >    return NULL;
> > switch (func_id) {
> > case BPF_FUNC_probe_write_user:
> >
> > that will align it with the style of bpf_base_func_proto().
> >
> > pw-bot: cr
>
> Ack, let me change that.
>
> Below is preview of v4 for this bit.

lgtm