linux-kernel - Re: [PATCH RFC/RFT 4/6] firmware: qcom: scm: Cleanup global '_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <503df6db-8937-4e1c-9c0e-0cc093681a8b@oss.qualcomm.com>
Date: Thu, 28 Nov 2024 21:25:25 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Mukesh Ojha
 <quic_mojha@...cinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Stephan Gerhold <stephan.gerhold@...aro.org>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Kuldeep Singh <quic_kuldsing@...cinc.com>,
        Elliot Berman <quic_eberman@...cinc.com>,
        Andrew Halaney <ahalaney@...hat.com>,
        Avaneesh Kumar Dwivedi <quic_akdwived@...cinc.com>,
        Andy Gross <andy.gross@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC/RFT 4/6] firmware: qcom: scm: Cleanup global '__scm'
 on probe failures

On 19.11.2024 8:37 PM, Krzysztof Kozlowski wrote:
> On 19/11/2024 19:33, Krzysztof Kozlowski wrote:
>>  	/*
>>  	 * Initialize the QSEECOM interface.
>> @@ -2094,6 +2104,12 @@ static int qcom_scm_probe(struct platform_device *pdev)
>>  	WARN(ret < 0, "failed to initialize qseecom: %d\n", ret);
>>  
>>  	return 0;
>> +
>> +err:
>> +	/* Paired with smp_load_acquire() in qcom_scm_is_available(). */
>> +	smp_store_release(&__scm, 0);
> Heh, I should store there NULL, obviously.

Candidate for a new scoped __free, perhaps?

Konrad