linux-kernel - Re: [PATCH] netfilter: uapi: Fix file names for case-insensitive filesystem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241129070805.GA26153@breakpoint.cc>
Date: Fri, 29 Nov 2024 08:08:05 +0100
From: Florian Westphal <fw@...len.de>
To: Szőke Benjamin <egyszeregy@...email.hu>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
	Florian Westphal <fw@...len.de>, kadlec@...filter.org,
	davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: uapi: Fix file names for case-insensitive
 filesystem.

Szőke Benjamin <egyszeregy@...email.hu> wrote:
> and lower case *.h files can be merged to a common header files like
> "xt_dscp_common.h" but what about the *.c sources? For example if xt_DSCP.c
> removed and its content merged to xt_dscp.c before, what is the plan with
> kernel config options of CONFIG_NETFILTER_XT_TARGET_DSCP which was made for
> only xt_DSCP.c source to use in Makefile? Can we remove all of
> CONFIG_NETFILTER_XT_TARGET* config in the future which will lost their *.c
> source files?

Sure.

> obj-$(CONFIG_NETFILTER_XT_TARGET_DSCP) += xt_DSCP.o
> ...

This line goes away.

> obj-$(CONFIG_NETFILTER_XT_MATCH_DSCP) += xt_dscp.o

This line is changed to

obj-$(CONFIG_NETFILTER_XT_DSCP) += xt_dscp.o

Kconfig file NETFILTER_XT_TARGET/MATCH_DSCP are changed to
select new NETFILTER_XT_MATCH_DSCP.

This has been done before, see e.g.
28b949885f80 ("netfilter: xtables: merge xt_MARK into xt_mark")

you can follow this almost 1:1.