linux-kernel - Re: [PATCH v5 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB11782E233EB153B2FBC5602CF22A2@MA0P287MB1178.INDP287.PROD.OUTLOOK.COM>
Date: Fri, 29 Nov 2024 12:17:25 +0000
From: Bhavin Sharma <bhavin.sharma@...iconsignals.io>
To: Krzysztof Kozlowski <krzk@...nel.org>, "sre@...nel.org" <sre@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>
CC: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>, Rob Herring
	<robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

Hi Krzysztof,

Thanks for the review

> > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
> > Signed-off-by: Bhavin Sharma <bhavin.sharma@...iconsignals.io>
>
> Your SoBs are odd... second patch has totally reversed path comparing to
> this one. What do you want to express here?

i will correct the order

> > +  sense-resistor:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: Current sense resistor in milliohms
>
> phandle cannot be in milliohms... Anyway, use existing widely used
> property: shunt-resistor-micro-ohms

okay

> > +      bat: battery {
> > +        compatible = "simple-battery";
> > +        charge-full-design-microamp-hours = <2600000>;
> > +        voltage-min-design-microvolt = <3300000>;
> > +        voltage-max-design-microvolt = <4250000>;
> > +      };
>
> Drop battery node, not needed for example.

okay 

> > +      battery@70 {
> > +        compatible = "st,stc3117";
> > +        reg = <0x70>;
> > +        interrupt-parent = <&gpio0>;
> > +        interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> 
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.

ohh yes , need to add bindings for interrupt 

Best Regards,
Bhavin