linux-kernel - Re: [PATCH v1 1/3] arm64: dts: qcom: sa8775p-ride: Change the BT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6ac4e53-7137-42fa-9cef-d3f4a5816960@quicinc.com>
Date: Fri, 29 Nov 2024 10:47:00 +0800
From: "Cheng Jiang (IOE)" <quic_chejiang@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Marcel Holtmann
	<marcel@...tmann.org>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        "Konrad Dybcio" <konradybcio@...nel.org>,
        Balakrishna Godavarthi
	<quic_bgodavar@...cinc.com>,
        Rocky Liao <quic_rjliao@...cinc.com>
CC: <linux-bluetooth@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <quic_zijuhu@...cinc.com>, <quic_jiaymao@...cinc.com>,
        <quic_mohamull@...cinc.com>
Subject: Re: [PATCH v1 1/3] arm64: dts: qcom: sa8775p-ride: Change the BT node

Hi Krzysztof,

On 11/28/2024 10:39 PM, Krzysztof Kozlowski wrote:
> On 28/11/2024 13:09, Cheng Jiang wrote:
>> The SA8775P-Ride uses the QCA6698 chipset, which shares the same IP core
>> as the WCN6855. However, it has different RF components and RAM sizes,
>> so new firmware is needed.  This change allows driver to distinguish it
>> from the WCN6855 and load the specific firmware.
>>
>> Signed-off-by: Cheng Jiang <quic_chejiang@...cinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> index 3fc62e123..f95e709bd 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> @@ -856,7 +856,7 @@ &uart17 {
>>  	status = "okay";
>>  
>>  	bluetooth {
>> -		compatible = "qcom,wcn6855-bt";
>> +		compatible = "qcom,qca6698-bt";
> 
> This breaks users without mentioning it, without really justifying the
> impact. Also it is not clear for me whether devices are or are not
> compatible.
QCA6698 can use the wcn6855 firmware, but the performance is not good as expect. 
To avoid breaking existing projects, we plan to upstream a new firmware for this
chip. 
If use the 'firmware-name' to specify the firmware, we can keep the compatible
here unchanged. Is it OK?
> 
> Best regards,
> Krzysztof