linux-kernel - Re: [PATCH v2] media: qcom: camss: fix VFE pm domain off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac765a062e94d549f4c34cf4c8b2c199@mainlining.org>
Date: Fri, 29 Nov 2024 14:46:10 +0100
From: barnabas.czeman@...nlining.org
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, Robert Foss
 <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, Hans Verkuil
 <hverkuil@...all.nl>, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, Yassine Oudjana
 <y.oudjana@...tonmail.com>
Subject: Re: [PATCH v2] media: qcom: camss: fix VFE pm domain off

On 2024-11-29 13:25, Bryan O'Donoghue wrote:
> On 29/11/2024 11:44, barnabas.czeman@...nlining.org wrote:
>>> The change does not describe how to reproduce the problem, which 
>>> commit
>>> base is tested, which platform is testes, there is no enough 
>>> information,
>>> unfortunately.
>> I can reproduce the problem with megapixels-sensorprofile on msm8953 
>> and
>> it can be reproduced with megapixels on msm8996.
>> The base is the last commit on next.
> 
> Can you verify if vfe_domain_on has run and if so whether or not 
> genpd_link is NULL when that function exists.
> 
I have added some debug logs it seems pm_domain_on and pm_domain_off is 
called twice on the same object.
[   63.473360] qcom-camss 1b00020.camss: pm_domain_on 19842ce8 link 
42973800
[   63.481524] qcom-camss 1b00020.camss: pm_domain_on 19840080 link 
4e413800
[   63.481555] qcom-camss 1b00020.camss: pm_domain_on 19842ce8 link 
42973800
[   63.481632] qcom-camss 1b00020.camss: pm_domain_off 19840080 link 
4e413800
[   63.481641] qcom-camss 1b00020.camss: pm_domain_off 19842ce8 link 
42973800
[   63.654004] qcom-camss 1b00020.camss: pm_domain_off 19842ce8 link 0
> That's the question.
> 
> ---
> bod