linux-kernel - Re: [PATCH v1 1/2] dt-bindings: iio: adc: Add binding for Nuvoton NCT720x ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d8e9512-2be8-4337-9791-0d956b0968c5@baylibre.com>
Date: Fri, 29 Nov 2024 08:50:28 -0600
From: David Lechner <dlechner@...libre.com>
To: Yu-Hsian Yang <j2anfernee@...il.com>, Jonathan Cameron <jic23@...nel.org>
Cc: Chanh Nguyen <chanh@...eremail.onmicrosoft.com>, avifishman70@...il.com,
 tmaimon77@...il.com, tali.perry1@...il.com, venture@...gle.com,
 yuenn@...gle.com, benjaminfair@...gle.com, lars@...afoo.de, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, nuno.sa@...log.com,
 javier.carrasco.cruz@...il.com, andy@...nel.org, marcelo.schmitt@...log.com,
 olivier.moysan@...s.st.com, mitrutzceclan@...il.com,
 matteomartelli3@...il.com, alisadariana@...il.com,
 joao.goncalves@...adex.com, marius.cristea@...rochip.com,
 mike.looijmans@...ic.nl, chanh@...amperecomputing.com, KWLIU@...oton.com,
 yhyang2@...oton.com, openbmc@...ts.ozlabs.org, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: iio: adc: Add binding for Nuvoton
 NCT720x ADCs

On 11/27/24 8:14 PM, Yu-Hsian Yang wrote:
> Dear Jonathan Cameron,
> 
> Thank you for your advice.
> 
> I would remove the "nvuoton,read-vin-data-size" property.
> 
> Read VIN info can use word read or byte read, and other registers
> should use byte read.
> If I use word read for VIN info and byte read for other registers,
> I encounter an issue when I use regmap instead of i2c smbus API.
> 
> I need two regmap configs with val_bits 8/16.
> After I call devm_regmap_init_i2c these two configs,
> the error message:
> "debugfs: Directory '5-001d' with parent 'regmap' already present!"
> 
> Do you have any suggestions?
> 
Give each regmap a unique name, like "5-001d-8bit" and "5-001d-16bit".