linux-kernel - Re: [PATCH v4 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78cd2bf3-d4e3-4da9-9a92-91ec15475071@kernel.org>
Date: Fri, 29 Nov 2024 16:12:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>,
 Rob Herring <robh@...nel.org>
Cc: konrad.dybcio@...aro.org, andersson@...nel.org, andi.shyti@...nel.org,
 linux-arm-msm@...r.kernel.org, dmaengine@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
 conor+dt@...nel.org, agross@...nel.org, devicetree@...r.kernel.org,
 vkoul@...nel.org, linux@...blig.org, dan.carpenter@...aro.org,
 Frank.Li@....com, konradybcio@...nel.org, bryan.odonoghue@...aro.org,
 krzk+dt@...nel.org, quic_vdadhani@...cinc.com
Subject: Re: [PATCH v4 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared
 flag

On 29/11/2024 15:43, Mukesh Kumar Savaliya wrote:
>> But most important: I keep repeating this over and over - NAK for some
>> specific "shared-se" flag, different for each of your IP blocks. Come
>> with something generic for entire qualcomm. There are few of such flags
>> already and there are some patches adding it in different flavors.
>>
> we do have SE (serial engine) which works for i2c, spi, uart, i3c. And 
> SE is single HW entity as you are aware of. But I feel it makes sense to 
> keep this flag name per SE and even for SPI OR I3C we should be using 
> same flag name in DTSI.
>> Get this consistent.
>>
>> NAK for this and v5 doing exactly theh same.
>>
> Hope i meet expectations considering all your suggestions and past 
> learning and not missing anything out of my mind.
> 
Nothing from my comment above was resolved. I will NAK the next version
as well for the same reasons.

Best regards,
Krzysztof