linux-kernel - Re: [PATCH RFT v12 4/8] fork: Add shadow stack support to clone3()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z0nyZDNn0rcgkKBJ@arm.com>
Date: Fri, 29 Nov 2024 16:57:08 +0000
From: Yury Khrustalev <yury.khrustalev@....com>
To: Mark Brown <broonie@...nel.org>
CC: "Rick P. Edgecombe" <rick.p.edgecombe@...el.com>, Deepak Gupta
	<debug@...osinc.com>, Szabolcs Nagy <Szabolcs.Nagy@....com>, "H.J. Lu"
	<hjl.tools@...il.com>, Florian Weimer <fweimer@...hat.com>, Thomas Gleixner
	<tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
	<bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>, Juri
 Lelli <juri.lelli@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt
	<rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, "Mel Gorman"
	<mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>, Christian
 Brauner <brauner@...nel.org>, Shuah Khan <shuah@...nel.org>,
	<linux-kernel@...r.kernel.org>, Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, <jannh@...gle.com>, Wilco Dijkstra
	<wilco.dijkstra@....com>, <linux-kselftest@...r.kernel.org>,
	<linux-api@...r.kernel.org>, Kees Cook <kees@...nel.org>
Subject: Re: [PATCH RFT v12 4/8] fork: Add shadow stack support to clone3()

On Thu, Oct 31, 2024 at 07:25:05PM +0000, Mark Brown wrote:
> Unlike with the normal stack there is no API for configuring the the shadow
> stack for a new thread, instead the kernel will dynamically allocate a new
> shadow stack with the same size as the normal stack. This appears to be due
> to the shadow stack series having been in development since before the more
> extensible clone3() was added rather than anything more deliberate.
> 
> Add a paramter to clone3() specifying the shadow stack pointer to use
> for the new thread, this is inconsistent with the way we specify the
> normal stack but during review concerns were expressed about having to
> identify where the shadow stack pointer should be placed especially in
> cases where the shadow stack has been previously active.  If no shadow
> stack is specified then the existing implicit allocation behaviour is
> maintained.
> 
> If a shadow stack pointer is specified then it is required to have an
> architecture defined token placed on the stack, this will be consumed by
> the new task.  If no valid token is present then this will be reported
> with -EINVAL.  This token prevents new threads being created pointing at
> the shadow stack of an existing running thread.
> 
> If the architecture does not support shadow stacks the shadow stack
> pointer must be not be specified, architectures that do support the
> feature are expected to enforce the same requirement on individual
> systems that lack shadow stack support.
> 
> Update the existing arm64 and x86 implementations to pay attention to
> the newly added arguments, in order to maintain compatibility we use the
> existing behaviour if no shadow stack is specified. Since we are now
> using more fields from the kernel_clone_args we pass that into the
> shadow stack code rather than individual fields.
> 
> Portions of the x86 architecture code were written by Rick Edgecombe.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

Acked-by: Yury Khrustalev <yury.khrustalev@....com>

> @@ -101,12 +103,14 @@ struct clone_args {
>  	__aligned_u64 set_tid;
>  	__aligned_u64 set_tid_size;
>  	__aligned_u64 cgroup;
> +	__aligned_u64 shadow_stack_pointer;
>  };
>  #endif
>  
> -#define CLONE_ARGS_SIZE_VER0 64 /* sizeof first published struct */
> -#define CLONE_ARGS_SIZE_VER1 80 /* sizeof second published struct */
> -#define CLONE_ARGS_SIZE_VER2 88 /* sizeof third published struct */
> +#define CLONE_ARGS_SIZE_VER0  64 /* sizeof first published struct */
> +#define CLONE_ARGS_SIZE_VER1  80 /* sizeof second published struct */
> +#define CLONE_ARGS_SIZE_VER2  88 /* sizeof third published struct */
> +#define CLONE_ARGS_SIZE_VER3  96 /* sizeof fourth published struct */

Acked.

Kind regards,
Yury