linux-kernel - Re: [PATCH] misc: Kconfig: Make MCHP_LAN966X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiDSCtVdPh4YX1pgRQ+M+KGTD+k5UPxWhZM09FBiT5+hDifjw@mail.gmail.com>
Date: Fri, 29 Nov 2024 18:57:09 +0100
From: Ricardo Ribalda <ribalda@...omium.org>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic <dragan.cvetic@....com>, 
	Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF, not
 select it

Thanks for the headsup

On Fri, 29 Nov 2024 at 18:45, Herve Codina <herve.codina@...tlin.com> wrote:
>
> Hi Ricardo,
>
> On Fri, 29 Nov 2024 10:41:17 +0000
> Ricardo Ribalda <ribalda@...omium.org> wrote:
>
> > Most (maybe all?) the drivers depend on OF instead of selecting it. This
> > is more convenient for CI because we can have test scripts that do:
> > make allyesconfig
> > scripts/config -d OF
> > make olddefconfig
> >
> > Without this patch, OF cannot be disabled that way.
> >
> > Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> > ---
> >  drivers/misc/Kconfig | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index 902c306bc972..2ea5f40ff4e4 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -612,8 +612,7 @@ config MARVELL_CN10K_DPI
> >
> >  config MCHP_LAN966X_PCI
> >       tristate "Microchip LAN966x PCIe Support"
> > -     depends on PCI
> > -     select OF
> > +     depends on PCI && OF
> >       select OF_OVERLAY
> >       select IRQ_DOMAIN
> >       help
> >
> > ---
> > base-commit: 7af08b57bcb9ebf78675c50069c54125c0a8b795
> > change-id: 20241129-lan966x-depend-8bc69b4954e5
> >
>
> Not sure it should be done that way (See [1]). Also I pointed out this
> patch in the discussion.
>

I have no strong opinion for my version or:

depends on PCI && OF_OVERLAY


Shall I send a v2 or you prefer to handle it yourself?

Regards!

> [1]  https://lore.kernel.org/all/dywwnh7ns47ffndsttstpcsw44avxjvzcddmceha7xavqjdi77@cqdgmpdtywol/
>
> Best regards,
> Hervé



-- 
Ricardo Ribalda