linux-kernel - [PATCH v2] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241129-lan966x-depend-v2-1-72bb9397f421@chromium.org>
Date: Fri, 29 Nov 2024 18:29:44 +0000
From: Ricardo Ribalda <ribalda@...omium.org>
To: Herve Codina <herve.codina@...tlin.com>, 
 Derek Kiernan <derek.kiernan@....com>, 
 Dragan Cvetic <dragan.cvetic@....com>, Arnd Bergmann <arnd@...db.de>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, linux-kernel@...r.kernel.org, 
 Ricardo Ribalda <ribalda@...omium.org>
Subject: [PATCH v2] misc: Kconfig: Make MCHP_LAN966X_PCI depend on
 OF_OVERLAY

Drivers should depend on configurations that can be user-configurable
instead of selecting them.

Without this patch, OF cannot be disabled this way:
make allyesconfig
scripts/config -d OF
make olddefconfig

Which is a typical test in CI systems like media-ci.

Now that we are at it, remove the dependency on OF, it will come
automatically from OF_OVERLAY.

Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
---
Changes in v2:
- Depend on OF_OVERLAY also
- Link to v1: https://lore.kernel.org/r/20241129-lan966x-depend-v1-1-603fc4996c4f@chromium.org
---
 drivers/misc/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 902c306bc972..d617105fbda7 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -613,8 +613,7 @@ config MARVELL_CN10K_DPI
 config MCHP_LAN966X_PCI
 	tristate "Microchip LAN966x PCIe Support"
 	depends on PCI
-	select OF
-	select OF_OVERLAY
+	depends on OF_OVERLAY
 	select IRQ_DOMAIN
 	help
 	  This enables the support for the LAN966x PCIe device.

---
base-commit: 7af08b57bcb9ebf78675c50069c54125c0a8b795
change-id: 20241129-lan966x-depend-8bc69b4954e5

Best regards,
-- 
Ricardo Ribalda <ribalda@...omium.org>