linux-kernel - Re: [PATCH] media: uvcvideo: Use uvc_query_name in uvc_get_video

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241129214321.GB2652@pendragon.ideasonboard.com>
Date: Fri, 29 Nov 2024 23:43:21 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Xiong Nandi <xndchn@...il.com>, Hans de Goede <hdegoede@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Use uvc_query_name in uvc_get_video_ctrl

On Fri, Nov 29, 2024 at 07:18:55PM +0100, Ricardo Ribalda wrote:
> On Fri, 29 Nov 2024 at 16:18, Xiong Nandi <xndchn@...il.com> wrote:
> >
> > uvc_query_name was introduced to print query name in uvc_query_ctrl.
> > So we can also use it in uvc_get_video_ctrl.
> >
> > Signed-off-by: Xiong Nandi <xndchn@...il.com>
> > ---
> >  drivers/media/usb/uvc/uvc_video.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> > index e00f38dd07d9..93cacd2c8721 100644
> > --- a/drivers/media/usb/uvc/uvc_video.c
> > +++ b/drivers/media/usb/uvc/uvc_video.c
> > @@ -297,8 +297,8 @@ static int uvc_get_video_ctrl(struct uvc_streaming *stream,
> >                 goto out;
> >         } else if (ret != size) {
> >                 dev_err(&stream->intf->dev,
> > -                       "Failed to query (%u) UVC %s control : %d (exp. %u).\n",
> > -                       query, probe ? "probe" : "commit", ret, size);
> > +                       "Failed to query (%s) UVC %s control : %d (exp. %u).\n",
> > +                       uvc_query_name(query), probe ? "probe" : "commit", ret, size);
>
> nit: This is above 80 characters. Please move size to the next line,
> aligned to uvc_query_name

I can make that change when applying the patch, no need to send a new
version.

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>


> With that change:
> 
> Reviewed-by: Ricardo Ribalda <ribalda@...omium.org>
> 
> >                 ret = (ret == -EPROTO) ? -EPROTO : -EIO;
> >                 goto out;
> >         }

-- 
Regards,

Laurent Pinchart