linux-kernel - Re: [GIT PULL] execve updates for v6.13-rc1 (take 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241129225423.GK3387508@ZenIV>
Date: Fri, 29 Nov 2024 22:54:23 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Vegard Nossum <vegard.nossum@...cle.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
	Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Nir Lichtman <nir@...htman.org>,
	Tycho Andersen <tandersen@...flix.com>
Subject: Re: [GIT PULL] execve updates for v6.13-rc1 (take 2)

On Fri, Nov 29, 2024 at 10:42:47PM +0100, Vegard Nossum wrote:

> Probably a silly question, but why not do the same thing in all cases?
> file->f_path.dentry->d_name.name _is_ the basename of whatever the
> normal path resolution machinery ended up with; why not use just it
> unconditionally? It handled empty paths already. This also seems to
> match what you wrote in https://lore.kernel.org/all/CAHk-=wgKgi5eqo6oW0bBS2-Cr+d4jraoKfVq6wbmdiWWsZbMLw@mail.gmail.com/
> (no argv[0], no magic strings, no symlinks):

User-visible change of behaviour, quite possibly confusing existing
scripts...

Let's not go there, it's a silly place.