linux-kernel - Re: [PATCH v5] sched/psi: fix memory barrier without comment warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpEso835Lqqz5ZpZJz5-iptcP3WMtY6g2moT2bOA1+bZ8Q@mail.gmail.com>
Date: Fri, 29 Nov 2024 15:04:07 -0800
From: Suren Baghdasaryan <surenb@...gle.com>
To: peterz@...radead.org, Pintu Agarwal <pintu.ping@...il.com>
Cc: Pintu Kumar <quic_pintu@...cinc.com>, hannes@...xchg.org, mingo@...hat.com, 
	juri.lelli@...hat.com, vincent.guittot@...aro.org, dietmar.eggemann@....com, 
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de, vschneid@...hat.com, 
	christophe.jaillet@...adoo.fr, linux-kernel@...r.kernel.org, joe@...ches.com, 
	skhan@...uxfoundation.org
Subject: Re: [PATCH v5] sched/psi: fix memory barrier without comment warnings

On Wed, Nov 27, 2024 at 5:25 PM Pintu Agarwal <pintu.ping@...il.com> wrote:
>
> Hi,
>
> On Wed, 23 Oct 2024 at 19:57, Pintu Agarwal <pintu.ping@...il.com> wrote:
> >
> > Hi,
> >
> > On Tue, 15 Oct 2024 at 02:36, Suren Baghdasaryan <surenb@...gle.com> wrote:
> > >
> > > On Sun, Oct 6, 2024 at 1:29 AM Pintu Kumar <quic_pintu@...cinc.com> wrote:
> > > >
> > > > These warnings were reported by checkpatch.
> > > > Fix them with minor changes.
> > > > No functional changes.
> > > >
> > > > WARNING: memory barrier without comment
> > > > +       t = smp_load_acquire(trigger_ptr);
> > > >
> > > > WARNING: memory barrier without comment
> > > > +       smp_store_release(&seq->private, new);
> > > >
> > > > Signed-off-by: Pintu Kumar <quic_pintu@...cinc.com>
> > >
> > > Acked-by: Suren Baghdasaryan <surenb@...gle.com>
> > >
> >
> > Any further comment on this ?
>
> Just a follow up. Are we picking this or I need to push again ?

I'm guessing it just fell through the cracks. Peter, could you please
pick it into your tree?
Thanks,
Suren.

>
> Thanks,
> Pintu