linux-kernel - Re: [syzbot] [netfs?] WARNING in netfs_retry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241129232325.2100-1-hdanton@sina.com>
Date: Sat, 30 Nov 2024 07:23:25 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+fe139f9822abd9855970@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [netfs?] WARNING in netfs_retry_reads

On Thu, Nov 28, 2024 at 11:27:24PM -0800, syzbot wrote:
> syzbot found the following issue on:
> 
> HEAD commit:    85a2dd7d7c81 Add linux-next specific files for 20241125
> git tree:       linux-next
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14e3a5c0580000

#syz test

--- x/fs/netfs/read_collect.c
+++ y/fs/netfs/read_collect.c
@@ -619,8 +619,7 @@ ssize_t netfs_wait_for_read(struct netfs
 
 	for (;;) {
 		trace_netfs_rreq(rreq, netfs_rreq_trace_wait_queue);
-		prepare_to_wait(&rreq->waitq, &myself, TASK_UNINTERRUPTIBLE);
-
+		smp_mb();
 		subreq = list_first_entry_or_null(&stream->subrequests,
 						  struct netfs_io_subrequest, rreq_link);
 		if (subreq &&
@@ -628,6 +627,7 @@ ssize_t netfs_wait_for_read(struct netfs
 		     test_bit(NETFS_SREQ_MADE_PROGRESS, &subreq->flags)))
 			netfs_read_collection(rreq);
 
+		prepare_to_wait(&rreq->waitq, &myself, TASK_UNINTERRUPTIBLE);
 		if (!test_bit(NETFS_RREQ_IN_PROGRESS, &rreq->flags))
 			break;
 
--