[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ce4210dc-9bd6-4b21-a7ff-f6a9afa22741@quicinc.com>
Date: Fri, 29 Nov 2024 12:55:02 +0800
From: fange zhang <quic_fangez@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Rob Clark <robdclark@...il.com>,
Abhinav Kumar
<quic_abhinavk@...cinc.com>,
Sean Paul <sean@...rly.run>,
Marijn Suijten
<marijn.suijten@...ainline.org>,
Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Rob Herring <robh@...nel.org>,
"Krzysztof
Kozlowski" <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"Krishna
Manikandan" <quic_mkrishn@...cinc.com>,
Bjorn Andersson
<andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
"Catalin
Marinas" <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, Li Liu
<quic_lliu6@...cinc.com>,
Xiangxu Yin <quic_xiangxuy@...cinc.com>,
<linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
<freedreno@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 9/9] arm64: dts: qcom: Add display support for QCS615
RIDE board
On 2024/11/26 6:08, Dmitry Baryshkov wrote:
> On Mon, 25 Nov 2024 at 09:39, fange zhang <quic_fangez@...cinc.com> wrote:
>>
>>
>>
>> On 2024/11/22 18:22, Dmitry Baryshkov wrote:
>>> On Fri, Nov 22, 2024 at 05:56:52PM +0800, Fange Zhang wrote:
>>>> From: Li Liu <quic_lliu6@...cinc.com>
>>>>
>>>> Add display MDSS and DSI configuration for QCS615 RIDE board.
>>>> QCS615 has a DP port, and DP support will be added in a later patch.
>>>>
>>>> Signed-off-by: Li Liu <quic_lliu6@...cinc.com>
>>>> Signed-off-by: Fange Zhang <quic_fangez@...cinc.com>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 76 ++++++++++++++++++++++++++++++++
>>>> 1 file changed, 76 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> index ee6cab3924a6d71f29934a8debba3a832882abdd..cc7dadc411ab79b9e60ccb15eaff84ea5f997c4c 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> @@ -202,6 +202,82 @@ &gcc {
>>>> <&sleep_clk>;
>>>> };
>>>>
>>>> +&i2c2 {
>>>> + clock-frequency = <400000>;
>>>> + status = "okay";
>>>> +
>>>> + ioexp: gpio@3e {
>>>> + compatible = "semtech,sx1509q";
>>>> + reg = <0x3e>;
>>>> + interrupt-parent = <&tlmm>;
>>>> + interrupts = <58 0>;
>>>> + gpio-controller;
>>>> + #gpio-cells = <2>;
>>>> + interrupt-controller;
>>>> + #interrupt-cells = <2>;
>>>> + semtech,probe-reset;
>>>> + };
>>>> +
>>>> + i2c-mux@77 {
>>>> + compatible = "nxp,pca9542";
>>>> + reg = <0x77>;
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> + i2c@0 {
>>>> + reg = <0>;
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + anx7625@58 {
>>>> + compatible = "analogix,anx7625";
>>>> + reg = <0x58>;
>>>> + interrupt-parent = <&ioexp>;
>>>> + interrupts = <0 0>;
>>>> + enable-gpios = <&tlmm 4 GPIO_ACTIVE_HIGH>;
>>>> + reset-gpios = <&tlmm 5 GPIO_ACTIVE_HIGH>;
>>>> + wakeup-source;
>>>> +
>>>> + ports {
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + port@0 {
>>>> + reg = <0>;
>>>> + anx_7625_in: endpoint {
>>>> + remote-endpoint = <&mdss_dsi0_out>;
>>>> + };
>>>> + };
>>>> +
>>>> + port@1 {
>>>> + reg = <1>;
>>>> + anx_7625_out: endpoint {
+ remote-endpoint = <&dp_connector_out>;
>>>> + };
>>>
>>> Where is it connected? Is it DP port? USB-C? eDP?
>> yes, it's DP port
>
> So, I'd expect to see a dp-connector node at the end, not the
> unterminated anx7625.
got it, will add it in next patch
+ dp-connector {
+ compatible = "dp-connector";
+ label = "DP";
+ type = "mini";
+
+ port {
+ dp_connector_out: endpoint {
+ remote-endpoint = <&anx_7625_out>;
+ };
+ };
+ };
>
>>>
>>>> + };
>>>> + };
>>>> + };
>>>> + };
>>>> + };
>>>> +};
>>>> +
>>>> +&mdss {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&mdss_dsi0 {
>>>> + vdda-supply = <&vreg_l11a>;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&mdss_dsi0_out {
>>>> + remote-endpoint = <&anx_7625_in>;
>>>> + data-lanes = <0 1 2 3>;
>>>> +};
>>>> +
>>>> +&mdss_dsi0_phy {
>>>> + vdds-supply = <&vreg_l5a>;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> &qupv3_id_0 {
>>>> status = "okay";
>>>> };
>>>>
>>>> --
>>>> 2.34.1
>>>>
>>>
>>
>
>
Powered by blists - more mailing lists