linux-kernel - Re: [syzbot] [block?] [trace?] possible deadlock in do_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFj5m9L0f8QVtevytwmgua8ZP4qjLLpm6DnKmP3gHZ+0evA0mg@mail.gmail.com>
Date: Sat, 30 Nov 2024 23:59:11 +0800
From: Ming Lei <ming.lei@...hat.com>
To: syzbot <syzbot+1682a0f52e34640bb386@...kaller.appspotmail.com>
Cc: axboe@...nel.dk, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, mathieu.desnoyers@...icios.com, 
	mhiramat@...nel.org, rostedt@...dmis.org, syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [block?] [trace?] possible deadlock in do_page_mkwrite (2)

On Sat, Nov 30, 2024 at 5:50 PM syzbot
<syzbot+1682a0f52e34640bb386@...kaller.appspotmail.com> wrote:
>
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:    7eef7e306d3c Merge tag 'for-6.13/dm-changes' of git://git...
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=11da21e8580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=ba7de3ed028e6710
> dashboard link: https://syzkaller.appspot.com/bug?extid=1682a0f52e34640bb386
> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
>
> Unfortunately, I don't have any reproducer for this issue yet.
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/450015008b3e/disk-7eef7e30.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/9bea6e0ac594/vmlinux-7eef7e30.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/e1b46c65494c/bzImage-7eef7e30.xz
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+1682a0f52e34640bb386@...kaller.appspotmail.com
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 6.12.0-syzkaller-09567-g7eef7e306d3c #0 Not tainted
> ------------------------------------------------------
> syz.5.3623/19452 is trying to acquire lock:
> ffff88805e392518 (sb_pagefaults){++++}-{0:0}, at: do_page_mkwrite+0x17a/0x380 mm/memory.c:3176
>
> but task is already holding lock:
> ffff888035510ba0 (&mm->mmap_lock){++++}-{4:4}, at: mmap_read_trylock include/linux/mmap_lock.h:163 [inline]
> ffff888035510ba0 (&mm->mmap_lock){++++}-{4:4}, at: get_mmap_lock_carefully mm/memory.c:6149 [inline]
> ffff888035510ba0 (&mm->mmap_lock){++++}-{4:4}, at: lock_mm_and_find_vma+0x35/0x6a0 mm/memory.c:6209
>
> which lock already depends on the new lock.
>
>
> the existing dependency chain (in reverse order) is:
>
> -> #6 (&mm->mmap_lock){++++}-{4:4}:
>        __might_fault mm/memory.c:6751 [inline]
>        __might_fault+0x11b/0x190 mm/memory.c:6744
>        _inline_copy_from_user include/linux/uaccess.h:162 [inline]
>        _copy_from_user+0x29/0xd0 lib/usercopy.c:18
>        copy_from_user include/linux/uaccess.h:212 [inline]
>        __blk_trace_setup+0xa8/0x180 kernel/trace/blktrace.c:626
>        blk_trace_setup+0x47/0x70 kernel/trace/blktrace.c:648
>        sg_ioctl_common drivers/scsi/sg.c:1114 [inline]
>        sg_ioctl+0x65e/0x2750 drivers/scsi/sg.c:1156
>        vfs_ioctl fs/ioctl.c:51 [inline]
>        __do_sys_ioctl fs/ioctl.c:906 [inline]
>        __se_sys_ioctl fs/ioctl.c:892 [inline]
>        __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:892
>        do_syscall_x64 arch/x86/entry/common.c:52 [inline]
>        do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
>        entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> -> #5 (&q->debugfs_mutex){+.+.}-{4:4}:

It should be fixed in:

git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
for-6.14/block

https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log/?h=for-6.14/block