linux-kernel - Re: [PATCH] hv_netvsc: Set device flags for properly indicating bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241130140307.3f0c028c@kernel.org>
Date: Sat, 30 Nov 2024 14:03:07 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: longli@...uxonhyperv.com
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang
 <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan Cui
 <decui@...rosoft.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Shradha
 Gupta <shradhagupta@...ux.microsoft.com>, Simon Horman <horms@...nel.org>,
 Konstantin Taranov <kotaranov@...rosoft.com>, Souradeep Chakrabarti
 <schakrabarti@...ux.microsoft.com>, Erick Archer
 <erick.archer@...look.com>, linux-hyperv@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Long Li
 <longli@...rosoft.com>
Subject: Re: [PATCH] hv_netvsc: Set device flags for properly indicating
 bonding

On Wed, 27 Nov 2024 11:42:50 -0800 longli@...uxonhyperv.com wrote:
> hv_netvsc uses a subset of bonding features in that the master always
> has only one active slave. But it never properly setup those flags.
> 
> Other kernel APIs (e.g those in "include/linux/netdevice.h") check for
> IFF_MASTER, IFF_SLAVE and IFF_BONDING for determing if those are used
> in a master/slave setup. 

I feel like this has been nacked 10 times already?
IFF_BONDING means the bonding driver.
There is more than one driver in the tree providing link aggregation
and only bonding uses IFF_BONDING. If some user is buggy fix the user.
-- 
pw-bot: reject