linux-kernel - drivers/platform/x86/x86-android-tablets/other.c:605:12: sparse: sparse: symbol 'crystal_cove_pwrsrc_psy' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202411301001.1glTy7Xm-lkp@intel.com>
Date: Sat, 30 Nov 2024 10:29:08 +0800
From: kernel test robot <lkp@...el.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Andy Shevchenko <andy@...nel.org>
Subject: drivers/platform/x86/x86-android-tablets/other.c:605:12: sparse:
 sparse: symbol 'crystal_cove_pwrsrc_psy' was not declared. Should it be
 static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2ba9f676d0a2e408aef14d679984c26373bf37b7
commit: 06f876def3469b44737df6c2efe6dd811838c9e7 platform/x86: x86-android-tablets: Add support for Vexia EDU ATLA 10 tablet
date:   3 weeks ago
config: i386-randconfig-061-20241130 (https://download.01.org/0day-ci/archive/20241130/202411301001.1glTy7Xm-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241130/202411301001.1glTy7Xm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411301001.1glTy7Xm-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/platform/x86/x86-android-tablets/other.c:605:12: sparse: sparse: symbol 'crystal_cove_pwrsrc_psy' was not declared. Should it be static?
>> drivers/platform/x86/x86-android-tablets/other.c:612:28: sparse: sparse: symbol 'vexia_edu_atla10_ulpmc_node' was not declared. Should it be static?

vim +/crystal_cove_pwrsrc_psy +605 drivers/platform/x86/x86-android-tablets/other.c

   600	
   601	/*
   602	 * Vexia EDU ATLA 10 tablet, Android 4.2 / 4.4 + Guadalinex Ubuntu tablet
   603	 * distributed to schools in the Spanish Andalucía region.
   604	 */
 > 605	const char * const crystal_cove_pwrsrc_psy[] = { "crystal_cove_pwrsrc" };
   606	
   607	static const struct property_entry vexia_edu_atla10_ulpmc_props[] = {
   608		PROPERTY_ENTRY_STRING_ARRAY("supplied-from", crystal_cove_pwrsrc_psy),
   609		{ }
   610	};
   611	
 > 612	const struct software_node vexia_edu_atla10_ulpmc_node = {
   613		.properties = vexia_edu_atla10_ulpmc_props,
   614	};
   615	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki