linux-kernel - Re: [PATCH] iio: adc: ti-ads124s08: Use gpiod_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241201130356.3bf4c693@jic23-huawei>
Date: Sun, 1 Dec 2024 13:03:56 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Fabio Estevam <festevam@...il.com>
Cc: lars@...afoo.de, dmurphy@...com, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] iio: adc: ti-ads124s08: Use gpiod_set_value_cansleep()

On Fri, 22 Nov 2024 13:43:08 -0300
Fabio Estevam <festevam@...il.com> wrote:

> Using gpiod_set_value() to control the reset GPIO causes some verbose
> warnings during boot when the reset GPIO is controlled by an I2C IO
> expander.
> 
> As the caller can sleep, use the gpiod_set_value_cansleep() variant to
> fix the issue.
> 
> Tested on a custom i.MX93 board with a ADS124S08 ADC.
> 
> Cc: <stable@...nel.org>
> Fixes: e717f8c6dfec ("iio: adc: Add the TI ads124s08 ADC code")
> Signed-off-by: Fabio Estevam <festevam@...il.com>
Hmm. Could be considered a feature, but fair enough as the change is
trivial and you are setting it on a real board.

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ti-ads124s08.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
> index 425b48d8986f..f452f57f11c9 100644
> --- a/drivers/iio/adc/ti-ads124s08.c
> +++ b/drivers/iio/adc/ti-ads124s08.c
> @@ -183,9 +183,9 @@ static int ads124s_reset(struct iio_dev *indio_dev)
>  	struct ads124s_private *priv = iio_priv(indio_dev);
>  
>  	if (priv->reset_gpio) {
> -		gpiod_set_value(priv->reset_gpio, 0);
> +		gpiod_set_value_cansleep(priv->reset_gpio, 0);
>  		udelay(200);
> -		gpiod_set_value(priv->reset_gpio, 1);
> +		gpiod_set_value_cansleep(priv->reset_gpio, 1);
>  	} else {
>  		return ads124s_write_cmd(indio_dev, ADS124S08_CMD_RESET);
>  	}