linux-kernel - Re: [PATCH v2 0/3] iio: adc: ad7173: fix non-const info struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241201133301.34163b29@jic23-huawei>
Date: Sun, 1 Dec 2024 13:33:01 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Dumitru Ceclan <mitrutzceclan@...il.com>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Nuno Sa <nuno.sa@...log.com>, Michael Walle
 <michael@...le.cc>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Uwe
 Kleine-König <u.kleine-koenig@...libre.com>, Guillaume
 Ranquet <granquet@...libre.com>
Subject: Re: [PATCH v2 0/3] iio: adc: ad7173: fix non-const info struct

On Sat, 30 Nov 2024 12:50:39 -0600
David Lechner <dlechner@...libre.com> wrote:

> On 11/30/24 12:43 PM, Jonathan Cameron wrote:
> > On Wed, 27 Nov 2024 14:01:52 -0600
> > David Lechner <dlechner@...libre.com> wrote:
> >   
> >> While working ad7124, Uwe pointed out a bug in the ad7173 driver.
> >> static struct ad_sigma_delta_info ad7173_sigma_delta_info was not const
> >> and was being modified during driver probe, which could lead to race
> >> conditions if two instances of the driver were probed at the same time.
> >>
> >> The actual fix part is fairly trivial but I have only compile tested it.
> >> Guillaume has access to ad4111 hardware, so it would be good to get a
> >> Tested-by from him to make sure this doesn't break anything.
> >>  
> > This is very big for a backport.  So I replied to previous version to suggest
> > instead duplicating the data before modifying.  That has much less code
> > movement and maybe a cleaner fix.  Perhaps we then cycle back to avoiding
> > that copy later.
> >   
> That is exactly what I did in v2. "iio: adc: ad7173: fix using shared
> static info struct" copies the struct before modifying it and is the
> only patch with a Fixes: tag.
> 

Oops - brain fart. Applied patch 1 for now to the fixes-togreg branch of iio.git
and marked it for stable.  I'll get the others once that's upstream.

Thanks,

Jonathan