linux-kernel - Re: [PATCH v2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB95QATT51L7FtVKdhTpTMo6sCwkihqyb5GtQBbLRR0jyRmMUg@mail.gmail.com>
Date: Sun, 1 Dec 2024 21:48:03 +0100
From: Eugene Shalygin <eugene.shalygin@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Li XingYang <yanhuoguifan@...il.com>, corbet@....net, jdelvare@...e.com, 
	linux-doc@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

Hi,

> >> This is an unrelated change. It affects other boards of the same family.
> >> It needs to be a separate patch, it needs to be explained, and it needs to
> >> get some confirmation that it works on the other boards of the same series.

> > I found that in the LibreHardwareMonitor project,
> > the registers used by Amd600 to operate FanCPUOpt are described:
> > https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/blob/master/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/EC/EmbeddedController.cs
> > BoardFamily.Amd600, new Dictionary<ECSensor, EmbeddedControllerSource>
> > {
> > { ECSensor.FanCPUOpt,  new EmbeddedControllerSource("CPU Optional Fan", SensorType.Fan, 0x00b0, 2) },
> > }
> >
> > I think this is suitable for the AMD 600 motherboard, and it does work on my motherboard as well.
>
> That makes sense, but it is still unrelated to this patch and, worse,
> not even mentioned in the patch description. See "Separate your changes"
> in Documentation/process/submitting-patches.rst.

Can confirm CPU_Opt is still at 0xb0 for ProArt X870E Creator Wifi, so
it is the same in AMD families 500 to 800. The introduction of the
sensor to the 600th family should not affect other boards, because
they do not use it yet,

Kind regards,
Eugene