linux-kernel - Re: [GIT PULL] vsnprintf: Removal of bprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z0zWos7Xh_w1gV1H@gallifrey>
Date: Sun, 1 Dec 2024 21:35:30 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
	Petr Mladek <pmladek@...e.com>, Andy Shevchenko <andy@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] vsnprintf: Removal of bprintf()

* Steven Rostedt (rostedt@...dmis.org) wrote:
> 
> Linus,
> 
> vsnprintf: Removal of bprintf()
> 
> - Remove unused bprintf() function
> 
>   bprintf() was added with the rest of the "bin-printf" functions.
>   These are functions that are used by trace_printk() that allows to
>   quickly save the format and arguments into the ring buffer without
>   the expensive processing of converting numbers to ASCII. Then on
>   output, at a much later time, the ring buffer is read and the string
>   processing occurs then. The bprintf() was added for consistency but
>   was never used. It can be safely removed.
> 
> [
>   Note, this was sent back in October, and since tracing is the only
>   user of the bin-printf code, I said I'll take it through my tree and
>   run it through all my tests. Unfortunately, that got lost in my todo
>   list and I was just reminded about it. I know it's the last day of
>   the merge window, but since this change just removes an unused
>   function, I decided to send it now. If you want me to wait for the
>   next merge window I can just add it to that queue. It passed all my
>   tests and I'm fine with having you take this now, or just adding it
>   to my queue for the next time.

Thanks!

Dave

> ]
> 
> Please pull the latest trace-printf-v6.13 tree, which can be found at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
> trace-printf-v6.13
> 
> Tag SHA1: b825aa3f0c933c2152598462f90eaed7e61a8804
> Head SHA1: f69e63756f7822fcdad8a34f9967e8b243e883ee
> 
> 
> Dr. David Alan Gilbert (1):
>       printf: Remove unused 'bprintf'
> 
> ----
>  include/linux/string.h |  1 -
>  lib/vsprintf.c         | 23 -----------------------
>  2 files changed, 24 deletions(-)
> ---------------------------
> commit f69e63756f7822fcdad8a34f9967e8b243e883ee
> Author: Dr. David Alan Gilbert <linux@...blig.org>
> Date:   Wed Oct 2 18:31:47 2024 +0100
> 
>     printf: Remove unused 'bprintf'
>     
>     bprintf() is unused. Remove it. It was added in the commit 4370aa4aa753
>     ("vsprintf: add binary printf") but as far as I can see was never used,
>     unlike the other two functions in that patch.
>     
>     Link: https://lore.kernel.org/20241002173147.210107-1-linux@treblig.org
>     Reviewed-by: Andy Shevchenko <andy@...nel.org>
>     Acked-by: Petr Mladek <pmladek@...e.com>
>     Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>     Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> 
> diff --git a/include/linux/string.h b/include/linux/string.h
> index 0dd27afcfaf7..493ac4862c77 100644
> --- a/include/linux/string.h
> +++ b/include/linux/string.h
> @@ -335,7 +335,6 @@ int __sysfs_match_string(const char * const *array, size_t n, const char *s);
>  #ifdef CONFIG_BINARY_PRINTF
>  int vbin_printf(u32 *bin_buf, size_t size, const char *fmt, va_list args);
>  int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf);
> -int bprintf(u32 *bin_buf, size_t size, const char *fmt, ...) __printf(3, 4);
>  #endif
>  
>  extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos,
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 6ac02bbb7df1..9d3dac38a3f4 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -3428,29 +3428,6 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)
>  }
>  EXPORT_SYMBOL_GPL(bstr_printf);
>  
> -/**
> - * bprintf - Parse a format string and place args' binary value in a buffer
> - * @bin_buf: The buffer to place args' binary value
> - * @size: The size of the buffer(by words(32bits), not characters)
> - * @fmt: The format string to use
> - * @...: Arguments for the format string
> - *
> - * The function returns the number of words(u32) written
> - * into @bin_buf.
> - */
> -int bprintf(u32 *bin_buf, size_t size, const char *fmt, ...)
> -{
> -	va_list args;
> -	int ret;
> -
> -	va_start(args, fmt);
> -	ret = vbin_printf(bin_buf, size, fmt, args);
> -	va_end(args);
> -
> -	return ret;
> -}
> -EXPORT_SYMBOL_GPL(bprintf);
> -
>  #endif /* CONFIG_BINARY_PRINTF */
>  
>  /**
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/