linux-kernel - Re: [PATCH] hfs: Sanity check the root record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <rdkuuboofty3nqjhmde667jwowcxnuo3q3mxcjrn3ip2xh2fhg@eo7aqzad775b>
Date: Sat, 30 Nov 2024 20:27:13 -0800
From: Leo Stone <leocstone@...il.com>
To: Jan Kara <jack@...e.cz>
Cc: syzbot+2db3c7526ba68f4ea776@...kaller.appspotmail.com, 
	brauner@...nel.org, quic_jjohnson@...cinc.com, viro@...iv.linux.org.uk, 
	sandeen@...hat.com, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	syzkaller-bugs@...glegroups.com, shuah@...nel.org, anupnewsmail@...il.com, 
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] hfs: Sanity check the root record

On Tue, Nov 26, 2024 at 10:52:54PM +0100, Jan Kara wrote:
> Yes, this strict check would make sense to me. I just don't know HFS good
> enough whether this is a safe assumption to make so it would be good to
> test with some HFS filesystem.

I tested with the System 7.5.3 install disks, as well as 2 disks I
formatted inside System 7 in an emulator. The root directory always had
entrylength of 70, and it looks like every directory has an entrylength
of 70.

I'll resend as a PATCH v2.

Thanks,
Leo