linux-kernel - Re: [PATCH] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241130225953.dbb95dbf5f6c785e931f45f7@linux-foundation.org>
Date: Sat, 30 Nov 2024 22:59:53 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Miaohe Lin <linmiaohe@...wei.com>
Cc: David Hildenbrand <david@...hat.com>, <nao.horiguchi@...il.com>,
 <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/memory-failure: fix
 VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory

On Mon, 5 Aug 2024 14:25:14 +0800 Miaohe Lin <linmiaohe@...wei.com> wrote:

> >>>> Yup, this will be a good alternative. But will it be better to simply check PagePoisoned() instead?
> >>>
> >>> The memmap of offline memory sections shall not be touched, so .... don't touch it ;)
> >>>
> >>> Especially because that PagePoisoned() check is non-sensical without poisoining-during-memmap-init. You would still work with memory in offline sections.
> >>>
> >>> I think the code is even wrong in that regard: we allow for memory offlining to work with HWPoisoned pages, see __offline_isolated_pages(). Staring at unpoison_memory(), we might be putting these pages back to the buddy? Which is completely wrong.
> >>
> >> I agree with you. Thanks for detailed explanation. :)
> >> Thanks David.
> > 
> > So ... I assume there will be a new patch? :)
> 
> I was just back from my two-weeks holidays. ;) I will try to send a new version when possible.

Maybe I missed the v2.  I'll drop this v1 patch.