linux-kernel - Re: [PATCH 2/2] iio: light: Add support for the AMS TCS3430 color sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241201115841.0ee49736@jic23-huawei>
Date: Sun, 1 Dec 2024 11:58:41 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Paul Kocialkowski <paulk@...-base.io>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH 2/2] iio: light: Add support for the AMS TCS3430 color
 sensor

On Sat, 30 Nov 2024 18:42:39 +0100
Paul Kocialkowski <paulk@...-base.io> wrote:

> The AMS TCS3430 is a XYZ tristimulus color sensor, with an additional
> infrared channel.
> 
> This driver implements support for all channels, with configurable
> integration time and gain. Both direct reading and triggered-buffer
> modes are supported.
> 
> The device's interrupt can be used to sample all channels at the end
> of conversion and is optional.
> 
> A thereshold mechanism is available in hardware but only applies to
> the Z channel. As a result it is of very low interest and was not
> implemented.
> 
> Signed-off-by: Paul Kocialkowski <paulk@...-base.io>

Hi Paul

As at least some of the feedback I gave on your other driver applies
here as well, I'm not going to review this version separately.

I'd generally advise against sending multiple similar drivers for review
at the same time as it is less efficient.  Sad truth is that reviewer
time is generally a bigger bottleneck for kernel code than the time
of driver authors.  Any time you can put in to help with that will generally
also accelerate the rate at which we get to your code!

Absolutely fine to overlap your submissions though. When the first
driver is getting close to being merged, feel free to send the second
one to get review started.

Thanks,

Jonathan