linux-kernel - Re: [PATCH 2/7] dtbindings: display: Fix BCM2835 HVS bindings for BCM2712

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36ea46ce-7add-4322-a030-1ee6c458d5db@kernel.org>
Date: Mon, 2 Dec 2024 16:18:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Eric Anholt <eric@...olt.net>,
 Maíra Canal <mcanal@...lia.com>,
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 Doug Berger <opendmb@...il.com>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH 2/7] dtbindings: display: Fix BCM2835 HVS bindings for
 BCM2712

On 02/12/2024 15:31, Dave Stevenson wrote:
> The previous patch adding the compatible string missed out that
> the number of interrupts and clocks changed with BCM2712 too.
> 
> Update to validate clock and interrupts for the variants.
> 
> Fixes: 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings")


No such commit on current next.

> Signed-off-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
> ---
>  .../bindings/display/brcm,bcm2835-hvs.yaml         | 77 +++++++++++++++++-----
>  1 file changed, 61 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
> index f91c9dce2a44..ab59edbcf32c 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
> @@ -19,12 +19,13 @@ properties:
>    reg:
>      maxItems: 1
>  
> -  interrupts:
> -    maxItems: 1
> +  interrupts: true

No, widest constrains are *always* here.

>  
> -  clocks:
> -    maxItems: 1
> -    description: Core Clock
> +  interrupt-names: true
> +
> +  clocks: true
> +
> +  clock-names: true


No, this has to be complete (widest) here.


>  
>  required:
>    - compatible
> @@ -33,17 +34,61 @@ required:
>  
Best regards,
Krzysztof