linux-kernel - Re: [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on BCM2712.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44c233d7-87d7-4dbb-a0d0-9e93ea497622@kernel.org>
Date: Mon, 2 Dec 2024 16:24:20 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Eric Anholt <eric@...olt.net>,
 Maíra Canal <mcanal@...lia.com>,
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 Doug Berger <opendmb@...il.com>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on
 BCM2712.

On 02/12/2024 15:32, Dave Stevenson wrote:
> Resolves the issues on clocks and power nodes

Which issues? Be specific. Such commit is unprecise and not really
helpful. We see it from the diff that this is "some issue". What we do
not see is WHY and WHAT the ISSUE is.

> 
> Fixes: 4254a647b6c9 ("arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT")
> Signed-off-by: Dave Stevenson <dave.stevenson@...pberrypi.com>

Nothing in the DTS patches suggested targeting DRM, so this patchset is
organized in pretty surprising way. Please split them per subsystem. DTS
is never for driver subsystem.

Subject: drop full stop.

> ---
>  arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> index fbc56309660f..26e05601416f 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> @@ -66,11 +66,7 @@ &sdio1 {
>  &soc {
>  	firmware: firmware {
>  		compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> -
>  		mboxes = <&mailbox>;
> -		dma-ranges;
>  
>  		firmware_clocks: clocks {
>  			compatible = "raspberrypi,firmware-clocks";
> @@ -85,6 +81,11 @@ reset: reset {
>  
>  	power: power {
>  		compatible = "raspberrypi,bcm2835-power";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +		dma-ranges;

No address space here, so why ranges?

> +
>  		firmware = <&firmware>;
>  		#power-domain-cells = <1>;
>  	};
> 

Best regards,
Krzysztof