linux-kernel - Re: [PATCH] ALSA: usb-audio: Fix a DMA to stack memory bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frn6umno.wl-tiwai@suse.de>
Date: Mon, 02 Dec 2024 16:31:23 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Benoît Sevens <bsevens@...gle.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	wangdicheng <wangdicheng@...inos.cn>,
	Manuel Barrio Linares <mbarriolinares@...il.com>,
	Lianqin Hu <hulianqin@...o.com>,
	Shen Lichuan <shenlichuan@...o.com>,
	Cyan Nyan <cyan.vtb@...il.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix a DMA to stack memory bug

On Mon, 02 Dec 2024 16:05:01 +0100,
Benoît Sevens wrote:
> 
> Hi Dan,
> 
> On Mon, 2 Dec 2024 at 13:57, Dan Carpenter <dan.carpenter@...aro.org> wrote:
> >
> > The usb_get_descriptor() function does DMA so we're not allowed
> > to use a stack buffer for that.  Doing DMA to the stack is not portable
> > all architectures.  Move the "new_device_descriptor" from being stored
> > on the stack and allocate it with kmalloc() instead.
> >
> 
> Thanks for fixing this. It looks good to me.
> 
> Note that the commit that is being fixed is already queued for
> backporting, so I don't know how this usually goes then.

We just follow the same pattern as the Linus upstream, applying the
fix on top of the previous fix.

In anyway, now I merged it.  Will be included in the next PR for rc2.

Thanks!


Takashi