linux-kernel - RE: [PATCH v1] drm/virtio: Set missing bo->attached flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH3PR11MB7177A6227543D9DE28564403F8352@CH3PR11MB7177.namprd11.prod.outlook.com>
Date: Mon, 2 Dec 2024 17:29:01 +0000
From: "Kasireddy, Vivek" <vivek.kasireddy@...el.com>
To: Dmitry Osipenko <dmitry.osipenko@...labora.com>, David Airlie
	<airlied@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>, Gurchetan Singh
	<gurchetansingh@...omium.org>, Chia-I Wu <olvaffe@...il.com>, "Kim, Dongwon"
	<dongwon.kim@...el.com>
CC: Rob Clark <robdclark@...il.com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "virtualization@...ts.linux.dev"
	<virtualization@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel@...labora.com" <kernel@...labora.com>
Subject: RE: [PATCH v1] drm/virtio: Set missing bo->attached flag

> Subject: [PATCH v1] drm/virtio: Set missing bo->attached flag
> 
> VirtIO-GPU driver now supports detachment of shmem BOs from host, but
> doing it only for imported dma-bufs. Mark all shmem BOs as attached, not
> just dma-bufs. This is a minor correction since detachment of a non-dmabuf
> BOs not supported today.
> 
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_prime.c | 1 -
>  drivers/gpu/drm/virtio/virtgpu_vq.c    | 3 +++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_prime.c
> b/drivers/gpu/drm/virtio/virtgpu_prime.c
> index 688810d1b611..33084ce1d01d 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_prime.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_prime.c
> @@ -249,7 +249,6 @@ static int virtgpu_dma_buf_init_obj(struct
> drm_device *dev,
>  	virtio_gpu_cmd_resource_create_blob(vgdev, bo, &params,
>  					    ents, nents);
>  	bo->guest_blob = true;
> -	bo->attached = true;
> 
>  	dma_buf_unpin(attach);
>  	dma_resv_unlock(resv);
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c
> b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index ad91624df42d..062639250a4e 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -1300,6 +1300,9 @@ virtio_gpu_cmd_resource_create_blob(struct
> virtio_gpu_device *vgdev,
> 
>  	virtio_gpu_queue_ctrl_buffer(vgdev, vbuf);
>  	bo->created = true;
> +
> +	if (nents)
> +		bo->attached = true;
Acked-by: Vivek Kasireddy <vivek.kasireddy@...el.com>

>  }
> 
>  void virtio_gpu_cmd_set_scanout_blob(struct virtio_gpu_device *vgdev,
> --
> 2.47.0