linux-kernel - Re: [RFC PATCH] resource: Fix CXL node not populated issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z03TeSrlI_8y4j89@smile.fi.intel.com>
Date: Mon, 2 Dec 2024 17:34:17 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Raghavendra K T <raghavendra.kt@....com>
Cc: linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
	bharata@....com, Huang Ying <ying.huang@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dan Williams <dan.j.williams@...el.com>,
	David Hildenbrand <david@...hat.com>,
	Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Alistair Popple <apopple@...dia.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Baoquan He <bhe@...hat.com>,
	ilpo.jarvinen@...ux.intel.com,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Fontenot Nathan <Nathan.Fontenot@....com>,
	Wei Huang <wei.huang2@....com>
Subject: Re: [RFC PATCH] resource: Fix CXL node not populated issue

On Mon, Dec 02, 2024 at 11:19:41AM +0000, Raghavendra K T wrote:
> Before:
> ~]$ numastat -m
> ...
>                           Node 0          Node 1           Total
>                  --------------- --------------- ---------------
> MemTotal               128096.18       128838.48       256934.65
> 
> After:
> $ numastat -m
> .....
>                           Node 0          Node 1          Node 2           Total
>                  --------------- --------------- --------------- ---------------
> MemTotal               128054.16       128880.51       129024.00       385958.67
> 
> Current patch reverts the effect of first commit where the issue is seen.
> 
> git bisect had led to below commit

Missed blank line here.

> Fixes: b4afe4183ec7 ("resource: fix region_intersects() vs add_memory_driver_managed()")

> Cc: Huang Ying <ying.huang@...el.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Davidlohr Bueso <dave@...olabs.net>
> Cc: Jonathan Cameron <jonathan.cameron@...wei.com>
> Cc: Dave Jiang <dave.jiang@...el.com>
> Cc: Alison Schofield <alison.schofield@...el.com>
> Cc: Vishal Verma <vishal.l.verma@...el.com>
> Cc: Ira Weiny <ira.weiny@...el.com>
> Cc: Alistair Popple <apopple@...dia.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Baoquan He <bhe@...hat.com>
> Cc: <ilpo.jarvinen@...ux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Fontenot Nathan <Nathan.Fontenot@....com>
> Cc: Wei Huang <wei.huang2@....com>

Isn't it too many to be included in the commit message? Note you may use the
same list with --cc in the command line with almost the same effect (almost --
no noise in the commit message).

> Signed-off-by: Raghavendra K T <raghavendra.kt@....com>
> ---

...

> +		bool is_type = (((p->flags & flags) == flags) &&
> +				((desc == IORES_DESC_NONE) ||
> +				 (desc == p->desc)));
> +
> +		if (resource_overlaps(p, &res))
> +			is_type ? type++ : other++;

Instead (if you will end up with this approach) please still use is_type_match().

-- 
With Best Regards,
Andy Shevchenko